Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BodyPix] Update BodyPix to v2.0.0 #628

Closed
joeyklee opened this issue Oct 15, 2019 · 2 comments
Closed

[BodyPix] Update BodyPix to v2.0.0 #628

joeyklee opened this issue Oct 15, 2019 · 2 comments

Comments

@joeyklee
Copy link
Contributor

Dear ml5 community,

I'm submitting a new issue. Please see the details below.

β†’ Step 1: Describe the issue πŸ“

Did you find a bug? Want to suggest an idea for feature?

  • suggesting an enhancement

β†’ Step 2: Screenshots or Relevant Documentation πŸ–Ό

Here's some helpful screenshots and/or documentation of the new feature

BodyPix 2.0 is out! - We should update this dep before making a new release. Also related to: #627

cc/ @shiffman @oveddan

@joeyklee joeyklee self-assigned this Oct 15, 2019
@joeyklee joeyklee changed the title Update BodyPix v2.0.0 Update BodyPix to v2.0.0 Oct 15, 2019
@oveddan
Copy link
Contributor

oveddan commented Oct 15, 2019

BodyPix 2.0 is way better! The segmentation masks now work for multiple people and are more accurate.

Also you can get a mask for each person.

I would make the ml5 api method take imageScaleFactor as an argument, as bodyPix 2.0 is soon going to change to that, and ml5 would internally handle setting inputResolution until the bodypix api is updated to take inputResolution at inference time.

See the discussion in this PR:
tensorflow/tfjs-models#313

@sproutleaf
Copy link
Contributor

See ml5js/ml5-next-gen#11!

@sproutleaf sproutleaf closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants