Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] CI testing is flaky #746

Closed
WenheLI opened this issue Dec 9, 2019 · 3 comments
Closed

[devops] CI testing is flaky #746

WenheLI opened this issue Dec 9, 2019 · 3 comments

Comments

@WenheLI
Copy link
Member

WenheLI commented Dec 9, 2019

While submitting a PR, the CI auto-testing past for node 8 and failed for node 10.
result
testing

This seems to be a potential issue with CI testing or test script?

@joeyklee
Copy link
Contributor

@WenheLI - this is an issue that has to do with a number of things, but foremost that it takes a long time for the pre-trained models to download from google when the models are called. Usually tests pass without a problem locally, so I have a feeling this has to do with the testing environment.

@tirtawr has suggested we consider doing pseudo-testing of our functions or rather that we don't run the CI testing on PRs on development, but rather just when we do releases. Not sure yet what the best way to handle this would be.

Maybe we just pay for a better machine? Would trying Github Actions maybe help with this?

@joeyklee
Copy link
Contributor

One thing I'm adding in #755 - is setting jasmine's random=false so that our tests run in sequence. This might help to address some of these funky issues!

@bomanimc bomanimc added the bug label Nov 25, 2020
@bomanimc
Copy link
Member

bomanimc commented Feb 16, 2021

Merging this issue into #637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants