Skip to content

Add test actions for mlc docker run #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

anandhu-eng
Copy link
Contributor

No description provided.

@anandhu-eng anandhu-eng requested a review from a team as a code owner February 17, 2025 11:45
Copy link

github-actions bot commented Feb 17, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

- name: Test --docker_detached for running in detached mode
run: |
mlc docker run --tags=detect,os --docker_detached
docker stop $(docker ps -aq)
Copy link
Contributor Author

@anandhu-eng anandhu-eng Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: There is no need for docker rm . Since we are supplying --rm while running the container here, the container automatically gets removed when it exits.

Edit: only applicable in docker detached mode

@arjunsuresh arjunsuresh merged commit 94f8fd5 into mlcommons:dev Feb 17, 2025
33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants