Skip to content

split the actions #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 87 commits into from
Feb 24, 2025
Merged

split the actions #108

merged 87 commits into from
Feb 24, 2025

Conversation

sahilavaran
Copy link
Contributor

No description provided.

@sahilavaran sahilavaran requested a review from a team as a code owner February 18, 2025 19:38
Copy link

github-actions bot commented Feb 18, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng
Copy link
Contributor

Hi @sahilavaran , it seems most of the tests are failing. Did you check whether its working on your local system?

During development we usually check by going to the main directory, instead of mlc action target, we would be using python3 -m mlc.main action target so that system level installation of the library is not necessary each time when we do modification.

@sahilavaran
Copy link
Contributor Author

@anandhu-eng Thanks for the feedback i will try again

@arjunsuresh arjunsuresh changed the title splitted the actions split the actions Feb 23, 2025
@arjunsuresh
Copy link
Contributor

@anandhu-eng I have fixed the import errors. But we need to decide the file name conventions before merging this PR.

@anandhu-eng
Copy link
Contributor

Hi @arjunsuresh , I think we can go with snake_case as the file name pattern. Eg; CacheAction.py will become cache_action.py

For the folder structure, how about the one below:

├── actions
│   ├── action_factory.py
│   ├── action.py
│   ├── cache
│   │   └── cache_action.py
│   ├── config
│   │   └── cfg_action.py
│   ├── experiment
│   │   └── experiment_action.py
│   ├── index.py
│   ├── item.py
│   ├── repo
│   │   ├── repo_action.py
│   │   └── repo.py
│   └── script
│       └── script_action.py
├── __init__.py
├── __main__.py
├── main.py
└── utils
    ├── logger.py
    └── utils.py

@anandhu-eng anandhu-eng marked this pull request as draft February 24, 2025 13:07
@sahilavaran sahilavaran marked this pull request as ready for review February 24, 2025 13:15
@arjunsuresh arjunsuresh merged commit e773d0c into mlcommons:dev Feb 24, 2025
33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants