Add missing LLVM operations #698
Draft
+843
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this not ready for reviews yet? |
|
Hi, I suppose it is. I haven't worked on it in a while and I had many issues related to LLVM 21's breaking changes with the LLVM dialect (annoyingly, no documentation, notice or examples on the new usage), specifically llvm.call iirc. If you have a better clue as to what needs to be done, or at least confirm what I did is correct then that would be good to go. The rest is up to your preference for the implementation of global values, which I'm still not super sure if it's the right way to go. Again, I'm very inexperienced with LLVM IR/MLIR. Appreciate your patience 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to add some LLVM dialect operations I required in my project and now contribute them upstream. I am not sure about the efficacy of some implementations, specifically GlobalValue. So I'm leaving it in draft mode to allow for feedback.
Hopefully everything else is ok.