Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter hash not entirely correct #723

Open
mb706 opened this issue May 22, 2023 · 1 comment
Open

filter hash not entirely correct #723

mb706 opened this issue May 22, 2023 · 1 comment
Assignees
@advieser

Comments

@mb706
Copy link
Collaborator

mb706 commented May 22, 2023

depends on mlr-org/mlr3filters#154
@mb706
Copy link
Collaborator Author

mb706 commented Sep 17, 2024

use filter$hash here:

mlr3pipelines/R/PipeOpFilter.R

Line 198 in f97409c

.additional_phash_input = function() class(self$filter)

but first need to fix filter hash in mlr3filters

advieser added a commit that referenced this issue Sep 22, 2024
@advieser
fixes #723, calling filter
3566800
@advieser advieser mentioned this issue Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@advieser advieser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mb706 @advieser