Skip to content

Commit 31e5750

Browse files
committed
Fix error handling for open file in ProxyManager
1 parent 9c2350a commit 31e5750

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/proxymanager.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,10 @@ void ProxyManager::generateVideoProxy(Mlt::Producer &producer,
106106

107107
// Touch file to make it in progress
108108
QFile file(fileName);
109-
file.open(QIODevice::WriteOnly);
109+
if (!file.open(QIODevice::WriteOnly)) {
110+
LOG_ERROR() << "Failed to open file for writing:" << fileName;
111+
return;
112+
}
110113
file.resize(0);
111114
file.close();
112115

@@ -380,7 +383,10 @@ void ProxyManager::generateImageProxy(Mlt::Producer &producer, bool replace)
380383

381384
// Touch file to make it in progress
382385
QFile file(fileName);
383-
file.open(QIODevice::WriteOnly);
386+
if (!file.open(QIODevice::WriteOnly)) {
387+
LOG_ERROR() << "Failed to open file for writing:" << fileName;
388+
return;
389+
}
384390
file.resize(0);
385391
file.close();
386392

@@ -444,7 +450,7 @@ static void processProperties(QXmlStreamWriter &newXml,
444450
propertiesRef = newProperties;
445451
}
446452
// Write all of the property elements
447-
for (const auto &p : propertiesRef) {
453+
for (auto &p : propertiesRef) {
448454
newXml.writeStartElement("property");
449455
newXml.writeAttribute("name", p.first);
450456
newXml.writeCharacters(p.second);

0 commit comments

Comments
 (0)