Add Duo MFA to Okta IdP client (#68)

* Add Duo MFA to Okta IdP client
* Add a "waiting for push mfa" prompt for Duo MFA with Okta client
* Update versions for dependencies

Update go module dependency versions
Update go linter version
Update circleci orb versions

Fix new linter findings

Author: mmmorris1975

.circleci/config.yml

@@ -4,15 +4,15 @@
 version: 2.1
 
 orbs:
-  go: circleci/go@1.5.0
-  aws-cli: circleci/aws-cli@1.3.2
-  ruby: circleci/ruby@1.1.2
-  windows: circleci/windows@2.4.0
+  go: circleci/go@1.7.0
+  aws-cli: circleci/aws-cli@1.4.1
+  ruby: circleci/ruby@1.2.0
+  windows: circleci/windows@2.4.1
 
 jobs:
   lint:
     docker:
-      - image: "golangci/golangci-lint:v1.37"
+      - image: "golangci/golangci-lint:v1.41"
 
     steps:
       - checkout
@@ -124,6 +124,7 @@ jobs:
 
     environment:
       AWS_SHARED_CREDENTIALS_FILE: build/aws_credentials
+      AWS_DEFAULT_REGION: us-east-1
 
     steps:
       - run: mkdir -p build

Makefile

@@ -64,7 +64,7 @@ $(BUILDDIR)/%:
 #	docker run --rm -e VER=$(VER) -v ${PWD}:/build --entrypoint /build/scripts/package.sh debian:stretch
 
 lint:
-	docker run --rm -v $${PWD}:/app -w /app -t golangci/golangci-lint:v1.37 golangci-lint run -v
+	docker run --rm -v $${PWD}:/app -w /app -t golangci/golangci-lint:v1.41 golangci-lint run -v
 
 clean:
 	rm -f $(EXE) $(EXE)-*-*-* $(EXE)*.rpm $(EXE)*.deb $(EXE)*.exe

cli/ssm_cmd.go

@@ -106,7 +106,7 @@ func execSsmPlugin(cfg aws.Config, in *ssm.StartSessionInput) error {
 	}
 
 	var ep aws.Endpoint
-	ep, err = cfg.EndpointResolver.ResolveEndpoint(ssm.ServiceID, cfg.Region)
+	ep, err = cfg.EndpointResolverWithOptions.ResolveEndpoint(ssm.ServiceID, cfg.Region)
 	if err != nil {
 		return err
 	}

client/external/http.go

@@ -55,7 +55,7 @@ func (r *httpRequest) withBody(body io.Reader) *httpRequest {
 		r.ContentLength = int64(t.Len())
 		rc = io.NopCloser(t)
 	case io.ReadCloser:
-		rc = t.(io.ReadCloser)
+		rc = t
 	default:
 		rc = io.NopCloser(t)
 	}

client/external/http_test.go

@@ -100,7 +100,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(nil)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength > -1 {
+		if r.ContentLength > -1 {
 			t.Error("invalid body")
 		}
 	})
@@ -111,7 +111,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(b)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength != int64(b.Len()) {
+		if r.ContentLength != int64(b.Len()) {
 			t.Error("invalid body")
 		}
 	})
@@ -122,7 +122,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(b)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength != int64(b.Len()) {
+		if r.ContentLength != int64(b.Len()) {
 			t.Error("invalid body")
 		}
 	})
@@ -133,7 +133,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(b)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength != int64(b.Len()) {
+		if r.ContentLength != int64(b.Len()) {
 			t.Error("invalid body")
 		}
 	})
@@ -144,7 +144,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(b)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength > -1 {
+		if r.ContentLength > -1 {
 			t.Error("invalid body")
 		}
 	})
@@ -155,7 +155,7 @@ func Test_withBody(t *testing.T) {
 		r, _ := newHttpRequest(context.Background(), http.MethodPost, "http://localhost")
 		r.withBody(b)
 
-		if _, ok := r.Body.(io.ReadCloser); !ok || r.ContentLength > -1 {
+		if r.ContentLength > -1 {
 			t.Error("invalid body")
 		}
 	})