Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the solver accept a flight less than 5 points? #231

Open
flyingtof opened this issue May 28, 2024 · 8 comments
Open

Could the solver accept a flight less than 5 points? #231

flyingtof opened this issue May 28, 2024 · 8 comments

Comments

@flyingtof
Copy link

flyingtof commented May 28, 2024

Hi,

With @vicb, we are working on the integration of igc-xc-score in flyxc. In some cases, the flights we are sending to the solver have less than 5 points. Under this limit, the solver returns an error.
Do you think that this limitation could be removed from igc-xc-score.
Would you accept a PR to solve this issue?

@vicb
Copy link
Contributor

vicb commented May 29, 2024

With @vicb

Christophe is actually doing all the work :)

But yes what would be nice is to be able to pass 2+ points - it is enough for free distance.

The use case is that @flyingtof is integrating the scoring into the XC Planner.

Next steps will be to score uploaded tracks and then live tracks.
I'm super happy to see the integration moving forward - many pilots have requested it.

I hope you're fine @mmomtchev !

@mmomtchev
Copy link
Owner

As you may have seen from my Github profile, I have been living on social welfare and in total isolation for the last 4 years because of a series of illegal judicial proceedings - which include some very serious sexually-motivated crimes - that an ex-employer of mine organized to cover his own problem. By now, this affairs involves the French police, many French judges, the EU justice system and many large IT companies, including Google, Twitter, Microsoft, Facebook and Amazon. In order to further intimidate me to stop discussing this affair, people are posting simultaneously Github issues. All open-source projects that I have been working in did accept to help with the extortion - including meson and conan which are the most recent ones. My position on this affair is that only a criminal moron would accept to do this, criminal for obvious reasons, and moron because I fail to see how anyone gains more than he loses, and that every tactic which depends on the whole world accepting to take part in an extortion can't be anything but a bluff by a desperate and mentally disturbed person.

@vicb
Copy link
Contributor

vicb commented May 29, 2024

Hum?
I'm sorry to hear that bu I'm not sure to understand what you expect from us?
I hope everything will turn ok for you.

@mmomtchev
Copy link
Owner

mmomtchev commented May 29, 2024

I do not expect anything, I am simply saying this every time someone does it.

@vicb
Copy link
Contributor

vicb commented May 29, 2024

does what?

And about the issue, would you accept a PR / answer questions we can have?

@mmomtchev
Copy link
Owner

Each time multiple persons posts simultaneously.

I wonder what would be the point of scoring of flight with less than 5 points.

It is the triangle algorithm which currently requires at least 5 points.

@vicb
Copy link
Contributor

vicb commented May 29, 2024

Chris is helping on flyxc and asked a question. I thought I would drop by and say hello, we haven't discussed in a long time. Sorry if it offended you, that was not the purpose.

We want to score any route created with the router and it starts from 2 points.

The current workaround Chris implemented is to extrapolate points. It would be better if solver return a score of 0 when they don't have enough points (i.e. 3 for triangles) instead of throwing.

@vicb
Copy link
Contributor

vicb commented Sep 27, 2024

We have solved this by duplicating the last point and trimming the indexes to the original length in the Solution.
It works fine for us.
Let me know if you have any interest in us upstreaming this.

Edit: Otherwise you can close the issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants