Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gathering feedback on API Proposal for state-space model #99

Open
jadrew43 opened this issue Jun 8, 2022 · 2 comments · May be fixed by #100
Open

Gathering feedback on API Proposal for state-space model #99

jadrew43 opened this issue Jun 8, 2022 · 2 comments · May be fixed by #100

Comments

@jadrew43
Copy link

jadrew43 commented Jun 8, 2022 •
edited by adam2392
Loading

As part of the Google Summer of Code program, I am constructing an API proposal to implement a state-space model using a Kalman Filter and an Expectation Maximization algorithm to estimate functional connectivity between regions of interest as recorded in M/EEG. The proposal also outlines the implementation of methods to compute the statistical significance between functionally connected networks.

This is my first API proposal so any feedback from variables to proposal structure is sincerely appreciated!

References:
@adam2392
Copy link
Member

adam2392 commented Jun 9, 2022

Great start! Left a few questions/comments.

If I misunderstood anything tho lmk.

@larsoner
Copy link
Member

Left a comment with my naive idea for a simpler API. My major suggestion is that we move to iterating via a WIP PR to this repo with a new examples/plot_meglds.py or so that someday will operate on sample data so that we can see the API in action, and pick the best starting (simple) API as possible

@adam2392 adam2392 linked a pull request Jun 17, 2022 that will close this issue
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GSOC] implement example of state-space model for connectivity jadrew43/mne-connectivity
3 participants
@larsoner @adam2392 @jadrew43