feat: introduce platform configs

Author: amanjeetsingh150

maestro-orchestra-models/src/main/java/maestro/orchestra/WorkspaceConfig.kt

@@ -9,11 +9,10 @@ data class WorkspaceConfig(
     val excludeTags: StringList? = null,
     val local: Local? = null,
     val executionOrder: ExecutionOrder? = null,
-    val iosIncludeNonModalElements: Boolean? = null,
     @Deprecated("not supported on maestro cloud") val baselineBranch: String? = null,
     val notifications: MaestroNotificationConfiguration? = null,
     @Deprecated("not supported now by default on cloud") val disableRetries: Boolean = false,
-    val deviceConfig: DeviceConfig? = null
+    val platform: PlatformConfiguration? = null,
 ) {
 
     data class MaestroNotificationConfiguration(
@@ -34,24 +33,18 @@ data class WorkspaceConfig(
         )
     }
 
-    data class DeviceConfig(
-        val android: List<TopLevelDeviceConfig>? = null,
-        val iOS: List<TopLevelDeviceConfig>? = null
+    data class PlatformConfiguration(
+        val android: AndroidConfiguration? = null,
+        val ios: IOSConfiguration? = null
     ) {
-        sealed class TopLevelDeviceConfig {
-            object DisableAnimations : TopLevelDeviceConfig()
+        data class AndroidConfiguration(
+            val disableAnimations: Boolean = false,
+        )
 
-            companion object {
-                @JsonCreator
-                @JvmStatic
-                fun fromValue(value: String): TopLevelDeviceConfig {
-                    return when (value) {
-                        "disableAnimations" -> DisableAnimations
-                        else -> throw IllegalArgumentException("Invalid deviceConfig: $value")
-                    }
-                }
-            }
-        }
+        data class IOSConfiguration(
+            val disableAnimations: Boolean = false,
+            val snapshotKeyHonorModalViews: Boolean? = null,
+        )
     }
 
     @JsonAnySetter

maestro-orchestra/src/test/java/maestro/orchestra/workspace/WorkspaceExecutionPlannerTest.kt

@@ -1,6 +1,8 @@
 package maestro.orchestra.workspace
 
 import com.google.common.truth.Truth.assertThat
+import maestro.orchestra.WorkspaceConfig
+import maestro.orchestra.WorkspaceConfig.*
 import org.junit.jupiter.api.Test
 import java.nio.file.Path
 import java.nio.file.Paths
@@ -339,28 +341,23 @@ internal class WorkspaceExecutionPlannerTest {
     }
 
     @Test
-    internal fun `016 - Upload Config gets correct values`() {
-        // When
-        val planWithoutConfig = WorkspaceExecutionPlanner.plan(
-            input = paths("/workspaces/000_individual_file"),
-            includeTags = listOf(),
-            excludeTags = listOf(),
-            config = null
-        )
-
-        val planWithIncludeNonModalElements = WorkspaceExecutionPlanner.plan(
-            input = paths("/workspaces/013_execution_order"),
-            includeTags = listOf(),
-            excludeTags = listOf(),
+    internal fun `017 - Upload configs on local and cloud both are supported`() {
+        // when
+        val plan = WorkspaceExecutionPlanner.plan(
+            input = paths("/workspaces/015_workspace_cloud_configs"),
+            includeTags = listOf("included"),
+            excludeTags = listOf("notIncluded"),
             config = null
         )
 
-        assertThat(planWithoutConfig.workspaceConfig.iosIncludeNonModalElements).isNull()
-        assertThat(planWithIncludeNonModalElements.workspaceConfig.iosIncludeNonModalElements).isTrue()
+        assertThat(plan.workspaceConfig.notifications?.email?.recipients).containsExactly("[email protected]")
+        assertThat(plan.workspaceConfig.notifications?.slack?.channels).containsExactly("e2e-testing")
+        assertThat(plan.workspaceConfig.executionOrder?.flowsOrder).containsExactly("flowA", "flowB")
+        assertThat(plan.workspaceConfig.disableRetries).isTrue()
     }
 
     @Test
-    internal fun `017 - Upload configs on local and cloud both are supported`() {
+    internal fun `017 - Upload platform configs on are supported`() {
         // when
         val plan = WorkspaceExecutionPlanner.plan(
             input = paths("/workspaces/015_workspace_cloud_configs"),
@@ -369,10 +366,13 @@ internal class WorkspaceExecutionPlannerTest {
             config = null
         )
 
-        assertThat(plan.workspaceConfig.notifications?.email?.recipients).containsExactly("[email protected]")
-        assertThat(plan.workspaceConfig.notifications?.slack?.channels).containsExactly("e2e-testing")
-        assertThat(plan.workspaceConfig.executionOrder?.flowsOrder).containsExactly("flowA", "flowB")
-        assertThat(plan.workspaceConfig.disableRetries).isTrue()
+        val platformConfiguration = plan.workspaceConfig.platform
+        assertThat(platformConfiguration).isEqualTo(
+            PlatformConfiguration(
+                android = PlatformConfiguration.AndroidConfiguration(disableAnimations = true),
+                ios = PlatformConfiguration.IOSConfiguration(disableAnimations = true, snapshotKeyHonorModalViews = false)
+            )
+        )
     }
 
     private fun path(path: String): Path? {

maestro-orchestra/src/test/resources/workspaces/015_workspace_cloud_configs/config.yaml

@@ -12,4 +12,10 @@ disableRetries: true
 executionOrder:
   flowsOrder:
     - flowA
-    - flowB
+    - flowB
+platform:
+  ios:
+    disableAnimations: true
+    snapshotKeyHonorModalViews: false
+  android:
+    disableAnimations: true