Makefile update to respect global poetry installs #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
IS_POETRY
checks for poetry command availability.install-poetry
only installs if virtual environment is activated, otherwise prints error messageCurrent behavior
The Makefile uses
pip freeze
to check for poetry.This requires poetry to either be installed in a global environment or in an activated virtual environment.
Installing will also fail due to PEP 668 unless a virtual environment is active.
Impact
The change respect multiple modern python tool workflows.
Poetry can be installed with pipx or uv as a globally available tool or locally in a virtual environment.
It also prints a simpler error message if neither is the case and a virtual environment is not activated.
One possibility is missing though, and that is the ability to run poetry without installing with uvx or pipx.
Does that need to be supported?
Checklist