enforceActions:'observed' is not work

[yumo-mt]

enforceActions: "observed" is not work, am i wrong ?

// mobx 6.0.4
import React, { useEffect } from "react";
import { observer } from "mobx-react";

import {
  makeAutoObservable,
  configure,
  makeObservable,
  action,
  observable
} from "mobx";

configure({
  enforceActions: "always"
});
class Store {
  constructor() {
    makeObservable(this, {
      data: observable
    });
  }
  data = "default";
}

const store = new Store();
@observer
class A extends React.Component {
  onChange = () => {
 // this onChange can change data ?  onChange is not action
    store.data = "change";
  };
  render() {
    return (
      <div>
        {store.data}
        <button onClick={this.onChange}>change</button>
      </div>
    );
  }
}

export default A;

[danielkcz]

Please, provide minimal runnable reproduction, we can't help you otherwise.

[yumo-mt]

update

[yumo-mt]

https://codesandbox.io/s/zen-dan-v7sgt?file=/src/App.js

[mweststrate]

It reports fine in the console as far as I can see? (We don't error on it, as semantically it will still correctly, just not very efficiently)

…

On Thu, Jan 21, 2021 at 10:56 AM Manster ***@***.***> wrote: https://codesandbox.io/s/zen-dan-v7sgt?file=/src/App.js — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2736 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBHNRPG2SOZE4WAED7LS3AB55ANCNFSM4WMRRNLA> .

[yumo-mt]

i mean enforceActions: "always" is strictness mode, button's onClick-> onChange is not action ,why it can change store.data ? Console show

Since strict-mode is enabled, changing (observed) observable values without using an action is not allowed. Tried to modify: [email protected]

why not a error ? like mobx3

Uncaught Error: [mobx] Invariant failed: Since strict-mode is enabled, changing observed observable values outside actions is not allowed. Please wrap the code in an `action` if this change is intended

[mweststrate]

we changed that a few major versions back, if you do a little digging in the changelog or issue tracker you can probably still find the reasons why.