-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompressible CoolProp tests do not compile #96
Comments
If line 49 is corrected to R_s then the next error is:
|
Exchanging X[xN] for X[:] in every mass fraction input resolved this for me. so in every function of ExternalMedia.Media.IncompressibleCoolPropMedium I changed the line to: |
That is weird though, as that test has @casella do you know what could be going on here? |
On the OM test suite, the tests
Test.CoolProp.Incompressible.IncompressibleCoolPropMedium
andTest.CoolProp.Incompressible.IncompressibleCoolPropMixture
does not compile withBecause
IncompressibleCoolPropMedium
extends fromModelica.Media.Interfaces.PartialMedium
(and not fromExternalMedia.BaseClasses.ExternalTwoPhaseMedium
), I'm pretty sureExternalMedia/Modelica/ExternalMedia/Media/IncompressibleCoolPropMedium.mo
Line 49 in 8f5df11
R_s
, notR
. Possibly this was overlooked in the MSL 3->4 transition?I dont know if this needs further fixes elsewhere.
The text was updated successfully, but these errors were encountered: