fix: Adds boolean support for Server.TryParse (#1605)

modernuo · Nov 21, 2023 · e680bdb · e680bdb
1 parent 03f850f
commit e680bdb
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/Projects/UOContent.Tests/Tests/Utilities/TryParseTests.cs b/Projects/UOContent.Tests/Tests/Utilities/TryParseTests.cs
@@ -0,0 +1,23 @@
+using Server;
+using System;
+using Xunit;
+
+namespace Server.Tests.Utility;
+
+public class TryParseTests
+{
+    [Theory]
+    [InlineData("True", null, true)]
+    [InlineData("False", null, false)]
+    [InlineData("Alakazam", "Not a valid boolean string.", true)]
+    public void TestTryParseBool(string value, string returned, bool parsedAs)
+    {
+        string actualReturned = Server.Types.TryParse(typeof(bool), value, out object constructed);
+        Assert.Equal(returned, actualReturned);
+
+        if (returned == null)
+        {
+            Assert.Equal(parsedAs, constructed);
+        }
+    }
+}
diff --git a/Projects/UOContent/Utilities/Types.cs b/Projects/UOContent/Utilities/Types.cs
@@ -187,6 +187,17 @@ public static string TryParse(Type type, string value, out object constructed)
                 return null;
             }
 
+            if (IsType(type, OfBool))
+            {
+                if (bool.TryParse(value, out bool parsed))
+                {
+                    constructed = parsed;
+                    return null;
+                }
+
+                return "Not a valid boolean string.";
+            }
+
             if (value.StartsWithOrdinal("0x") && IsNumeric(type))
             {
                 try