Skip to content

Commit b607115

Browse files
committedApr 24, 2024
Resolve "Fix performance for parallel sampling with mc backend"
1 parent 7a3cd33 commit b607115

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Changelog
22

33
## Latest
4+
- [#88](https://jugit.fz-juelich.de/IBG-1/ModSim/hopsy/-/issues/88): Fix parallelization for sampling with mcbackend as sample storage
45
- [#123](https://jugit.fz-juelich.de/IBG-1/ModSim/hopsy/-/issues/123): Add parallel tempering support for non-MPI users
56
- [#137](https://jugit.fz-juelich.de/IBG-1/ModSim/hopsy/-/issues/137): Fix rare bug for users implementing their own PyProposals for non-uniform sampling
67
- [#136](https://jugit.fz-juelich.de/IBG-1/ModSim/hopsy/-/issues/136): Improve numerical stability of mixture models

‎requirements-dev.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
docov
2+
docov
23
pre-commit
34
setuptools
45
wheel
5-
docov

‎setup.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ def build_extension(self, ext):
7474
cmake_args.append("-DHOPSY_BUILD_ID={}".format(commit_hash))
7575
except Exception as e:
7676
commit_hash = commit
77-
print("ERROR retrieving commit hash automatically. Build ID is set to", commit_hash)
77+
print(
78+
"ERROR retrieving commit hash automatically. Build ID is set to",
79+
commit_hash,
80+
)
7881

7982
if self.compiler.compiler_type != "msvc":
8083
# Using Ninja-build since it a) is available as a wheel and b)
@@ -112,9 +115,9 @@ def build_extension(self, ext):
112115
# self.parallel is a Python 3 only way to set parallel jobs by hand
113116
# using -j in the build_ext call, not supported by pip or PyPA-build.
114117
build_args += ["-j16"]
115-
#if hasattr(self, "parallel") and self.parallel:
116-
# CMake 3.12+ only.
117-
#build_args += ["-j{}".format(self.parallel)]
118+
# if hasattr(self, "parallel") and self.parallel:
119+
# CMake 3.12+ only.
120+
# build_args += ["-j{}".format(self.parallel)]
118121

119122
if not os.path.exists(self.build_temp):
120123
os.makedirs(self.build_temp)

0 commit comments

Comments
 (0)
Please sign in to comment.