Skip to content

Potential error in updateById and Mongoose adapter  #360

@kree-alltold

Description

@kree-alltold

Hi, I have been using moleculer-db with the mongoose adapter successfully for several months now. I am not sure why this issue is just now showing itself, but I have noticed two potential problems, one in the adapter and one in the core db service code.

  1. In _update() you call beforeEntityChanged() here, but there is not corresponding call to entityChanged()` at the end of the function.
  2. In the mongoose adapter the method updateById() returns a Query object. For some reason I just started having to explicitly call exec() on the returned query to get a doc that I can send to transformDocuments(), otherwise I was getting the error enity.toJSON() is not a function.

Note that I use _update() (or the update action) when possible, however, there are cases where I need to do a more complicated update operation than what the db adapter supports and I call updateById directly and then call transformDocuments.

Any ideas if either of these are actual bugs in the code, or is this working as intended and I am must have done something else that broke things.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions