Skip to content

Commit 5f942d1

Browse files
humza1400talkor
andauthored
fix(Tipseen): resolve invalid HTML structure and ref/id prop issues (#2799)
Co-authored-by: Tal Koren <[email protected]>
1 parent b9895e5 commit 5f942d1

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/core/src/components/Tipseen/Tipseen.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,11 @@ const Tipseen = forwardRef(
193193
}, [color, closeButtonTheme]);
194194

195195
const TipseenWrapper = ref || id ? "div" : Fragment;
196+
const wrapperProps =
197+
TipseenWrapper === "div"
198+
? { ref: mergedRef, id, "data-testid": dataTestId || getTestId(ComponentDefaultTestId.TIPSEEN, id) }
199+
: {};
200+
196201
const tooltipContent = (
197202
<div>
198203
<div className={cx(styles.tipseenHeader)}>
@@ -213,14 +218,14 @@ const Tipseen = forwardRef(
213218
)}
214219
<TipseenTitle text={title} className={cx(styles.tipseenTitle, titleClassName)} />
215220
</div>
216-
<Text color={textColor} type="text2" element="p" className={cx(styles.tipseenContent)}>
221+
<Text color={textColor} type="text2" element="div" ellipsis={false} className={cx(styles.tipseenContent)}>
217222
<TipseenContext.Provider value={color}>{content}</TipseenContext.Provider>
218223
</Text>
219224
</div>
220225
);
221226

222227
return (
223-
<TipseenWrapper ref={mergedRef} id={id} data-testid={dataTestId || getTestId(ComponentDefaultTestId.TIPSEEN, id)}>
228+
<TipseenWrapper {...wrapperProps}>
224229
<Tooltip
225230
className={cx(styles.tipseenWrapper, className, {
226231
[styles.tipseenWrapperWithoutCustomWidth]: !width,

0 commit comments

Comments
 (0)