Skip to content

Make API request functions protected #124

@ainsleyclark

Description

@ainsleyclark

Hi,

It would be useful for consumers to extend the API class for integrating other requests such as /trade-account.

The functions that are currently in the API class are set to private.

It would be good to make all of them protected for easier extensibility. Currently, the API class is only instantiated, not extended so I don't think this would have any major impact on the current design.

private function request( $path, $method = 'GET', $body = null ) {

private function validate_remote_result( $url, $result ) {

private function get( $path, $parameters = null ) {

private function patch( $path, array $body = null ) {

private function put( $path, array $body = null ) {

private function post( $path, array $body = null ) {

As well as the settings:

private $global_settings;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions