CLOUDP-77990: Adds linter. (#13)

Author: Rodrigo Valin

.evergreen.yml

@@ -5,38 +5,57 @@ functions:
     params:
       directory: sonar
 
-  tests_unit:
-  # 1. Create virtualenv
-  - command: subprocess.exec
+  python_venv: &python_venv
+    command: subprocess.exec
     type: setup
     params:
       command: virtualenv --python /opt/python/3.7/bin/python3 ./venv
-  # 2. Install dependencies
-  - command: subprocess.exec
+
+  python_requirements: &python_requirements
+    command: subprocess.exec
     type: setup
     params:
       working_dir: sonar
-      command: ${workdir}/venv/bin/python -m pip install -r requirements.txt --quiet --no-warn-script-location
-  # 3. Install sonar package
-  - command: subprocess.exec
+      command: ${workdir}/venv/bin/python -m pip install -r requirements-dev.txt --quiet --no-warn-script-location
+
+  sonar_install: &sonar_install
+    command: subprocess.exec
     type: setup
     params:
       working_dir: sonar
       command: ${workdir}/venv/bin/python setup.py install
-  # 4. Run pytest
+
+  tests_unit:
+  - *python_venv
+  - *python_requirements
+  - *sonar_install
   - command: subprocess.exec
     type: test
     params:
       working_dir: sonar
       command: ${workdir}/venv/bin/python -m pytest
 
+  tests_lint:
+  - *python_venv
+  - *python_requirements
+  - command: subprocess.exec
+    type: test
+    params:
+      working_dir: sonar
+      command: ${workdir}/venv/bin/python -m pylint sonar/ --fail-under=8 
+    
 tasks:
 - name: tests_unit
   tags: ["tests"]
   commands:
   - func: fetch_source
   - func: tests_unit
 
+- name: tests_lint
+  tags: ["tests"]
+  commands:
+  - func: fetch_source
+  - func: tests_lint
 
 buildvariants:
 - name: tests_unit
@@ -46,3 +65,4 @@ buildvariants:
   stepback: true
   tasks:
   - name: tests_unit
+  - name: tests_lint

requirements-dev.txt

@@ -4,3 +4,4 @@ rope
 black
 flake8
 autopep8
+pylint==2.6.0