Make codechecker happy again

Author: abias

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2025-10-15 - Make codechecker happy again
 * 2025-10-15 - Tests: Switch Github actions workflows to reusable workflows by Moodle an Hochschulen e.V.
 
 ### v4.5-r4

classes/eventobservers.php

@@ -44,16 +44,13 @@ public static function user_created(\core\event\base $event) {
 
         // Do only if user id is enclosed in $eventdata.
         if (!empty($event->relateduserid)) {
-
             // Get user data.
             $user = $DB->get_record('user', ['id' => $event->relateduserid]);
 
             // Do if user was found.
             if (!empty($user->username)) {
-
                 // Do only if user has ldap_syncplus authentication.
                 if (isset($user->auth) && $user->auth == 'ldap_syncplus') {
-
                     // Update user.
                     // Actually, we would want to call auth_plugin_base::update_user_record()
                     // which is lighter, but this function is unfortunately protected since Moodle 3.5.

classes/privacy/provider.php

@@ -32,7 +32,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements \core_privacy\local\metadata\null_provider {
-
     /**
      * Get the language string identifier with the component's language
      * file to explain why this plugin stores no data.

classes/task/sync_roles.php

@@ -32,15 +32,14 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class sync_roles extends \core\task\scheduled_task {
-
     /**
      * Constructor.
      */
     public function __construct() {
         global $CFG;
 
         // Require local library.
-        require_once($CFG->dirroot.'/auth/ldap_syncplus/locallib.php');
+        require_once($CFG->dirroot . '/auth/ldap_syncplus/locallib.php');
 
         // No need to call parent constructor as it does not exist.
     }
@@ -80,5 +79,4 @@ public function execute() {
             }
         }
     }
-
 }

classes/task/sync_task.php

@@ -44,7 +44,7 @@ public function __construct() {
         global $CFG;
 
         // Require local library.
-        require_once($CFG->dirroot.'/auth/ldap_syncplus/locallib.php');
+        require_once($CFG->dirroot . '/auth/ldap_syncplus/locallib.php');
 
         // No need to call parent constructor as it does not exist.
     }

db/upgrade.php

@@ -54,8 +54,11 @@ function xmldb_auth_ldap_syncplus_upgrade($oldversion) {
 
     if ($oldversion < 2021072003) {
         // Normalize the memberattribute_isdn plugin config.
-        set_config('memberattribute_isdn',
-                !empty(get_config('auth_ldap_syncplus', 'memberattribute_isdn')), 'auth_ldap');
+        set_config(
+            'memberattribute_isdn',
+            !empty(get_config('auth_ldap_syncplus', 'memberattribute_isdn')),
+            'auth_ldap'
+        );
 
         upgrade_plugin_savepoint(true, 2021072003, 'auth', 'ldap_syncplus');
     }