New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lib.php #10

Open

abias opened this issue Nov 30, 2021 · 0 comments

Member

abias commented Nov 30, 2021

By definition, lib.php should be as small as possible:

Moodle core often (but not always) loads all the lib.php files of the given plugin types. For the performance reasons, it is strongly recommended to keep this file as small as possible and have just required code implemented in it

Source: https://docs.moodle.org/dev/Plugin_files#lib.php

In this plugin, some additional functions are located in lib.php which could be moved to a locallib.php or to autoloaded classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment