Skip to content

Commit 19de74e

Browse files
author
Sangyul Cha
committed
Bugfix: Site support form success message is shown below blocks or advert tiles on frontpage, resolves #488
1 parent 04fb9d8 commit 19de74e

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Changes
66

77
### v5.0-r11
88

9+
* 2025-10-24 - Bugfix: Site support form success message is shown below blocks or advert tiles on frontpage, resolves #488
910
* 2025-10-22 - Bugfix: Solve possible performance issues due to hook override cache being invalidated by CLI scripts, resolves #1076
1011
* 2025-10-21 - Tests: Some Behat tests for smart menus failed on 5.0, resolves #1074
1112
* 2025-10-15 - Make codechecker happy again

templates/theme_boost/drawers.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@
199199
{{> core/moremenu}}
200200
</div>
201201
{{/secondarymoremenu}}
202+
{{{ output.course_content_header }}}
202203
{{#regions.contentupper.hasblocks}}
203204
<section id="theme-block-region-content-upper" class="theme-block-region" aria-label="{{#str}}blocks{{/str}}">
204205
{{{ regions.contentupper.addblockbutton }}}
@@ -217,7 +218,6 @@
217218
{{#hasregionmainsettingsmenu}}
218219
<div class="region_main_settings_menu_proxy"></div>
219220
{{/hasregionmainsettingsmenu}}
220-
{{{ output.course_content_header }}}
221221
{{#headercontent}}
222222
{{> core/activity_header }}
223223
{{/headercontent}}

tests/behat/theme_boost_union_accessibilitysettings_support.feature

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,25 @@ Feature: Configuring the theme_boost_union plugin for the "Support page" tab on
236236
Then I should see "Your accessibility support request was sent"
237237
# Unfortunately, the content of the email can't be tested with Behat yet as we do not have a way to test sent emails yet.
238238

239+
@javascript
240+
Scenario: Support form success notification is shown before content-upper blocks on the homepage
241+
Given the following config values are set as admin:
242+
| config | value | plugin |
243+
| defaulthomepage | Home | |
244+
| enableaccessibilitysupport | yes | theme_boost_union |
245+
| blockregionsforfrontpage | content-upper | theme_boost_union |
246+
And the following "blocks" exist:
247+
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
248+
| online_users | Course | Acceptance test site | site-index | content-upper |
249+
When I log in as "admin"
250+
And I am on site homepage
251+
And I should see "Online users" in the "#theme-block-region-content-upper" "css_element"
252+
And I am on accessibilitysupport page
253+
And I set the field "Message" to "Frontpage notification order test"
254+
And I click on "Submit" "button"
255+
And I wait until the page is ready
256+
Then "Your accessibility support request was sent" "text" should appear before ".block_online_users" "css_element"
257+
239258
# Unfortunately, this can't be tested with Behat yet as we do not have a way to test sent emails yet (or rather block the sending of the email).
240259
# Scenario: Sending the accessibility support form fails and the fallback message is shown
241260

0 commit comments

Comments
 (0)