Bugfix: When upgrading a Boost Union installation from the ancient pre-smart-menu-era to a recent version, Boost Union tried to access a table which does not exist yet, resolves #1085 (#1091)

Author: abias

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2025-11-04 - Bugfix: When upgrading a Boost Union installation from the ancient pre-smart-menu-era to a recent version, Boost Union tried to access a table which does not exist yet, resolves #1085
 * 2025-11-03 - Glitch: upgrade.php did not match install.xml regarding the theme_boost_union_snippets table, resolves #1062
 * 2025-11-03 - Improvement: Use human-understandable values in the background position settings, resolves #1086
 * 2025-10-23 - Feature: Add a type for smart menu item to use mailto links, resolves #702

classes/smartmenu_item.php

@@ -28,6 +28,7 @@
 
 use context_system;
 use stdClass;
+use xmldb_table;
 use cache;
 use core\output\html_writer;
 use core_course\external\course_summary_exporter;
@@ -1879,6 +1880,15 @@ public static function image_filepickeroptions() {
     public static function get_all_fa_icons() {
         global $DB;
 
+        // Check if the menuitems table exists before trying to query it.
+        // This prevents errors during upgrades from versions where this table does not exist yet.
+        $dbman = $DB->get_manager();
+        $table = new xmldb_table('theme_boost_union_menuitems');
+        if (!$dbman->table_exists($table)) {
+            // If table doesn't exist, return empty array.
+            return [];
+        }
+
         // Define the query to search for icons in the menu items table.
         $sql = "SELECT DISTINCT menuicon
                 FROM {theme_boost_union_menuitems}