Tests: Add tests for Boost Union features which might but must not affect other active themes, resolves #761 (#1072)

Author: abias

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2025-10-20 - Tests: Add tests for Boost Union features which might but must not affect other active themes, resolves #761
 * 2025-10-16 - Feature: Add Bootstrap alert to Boost Union settings if Boost Union (or Boost Union Child) is not the active theme, resolves #773.
 * 2025-10-15 - Improvement: On course cards, display the course fields as Bootstrap badges, resolves #1070
 

locallib.php

@@ -2167,6 +2167,7 @@ function theme_boost_union_callbackimpl_before_standard_html(&$hook = null) {
         if ($hook != null) {
             // Add the HTML code to the hook.
             $hook->add_html($html);
+            return;
         } else {
             // Return the HTML code.
             return $html;
@@ -2179,6 +2180,7 @@ function theme_boost_union_callbackimpl_before_standard_html(&$hook = null) {
     if ($hook != null) {
         // Add the HTML code to the hook.
         $hook->add_html($html);
+        return;
     } else {
         // Return the HTML code.
         return $html;

tests/behat/theme_boost_union_accessibilitysettings_support.feature

@@ -49,6 +49,18 @@ Feature: Configuring the theme_boost_union plugin for the "Support page" tab on
       | yes     | should      |
       | no      | should not  |
 
+  Scenario: Setting: Enable accessibility support page - Do not add the screen reader link to the page if Boost Union is not the active theme (cross-theme check).
+    Given I log in as "admin"
+    And the following config values are set as admin:
+      | config                     | value | plugin            |
+      | enableaccessibilitysupport | yes   | theme_boost_union |
+    And I navigate to "Appearance > Themes" in site administration
+    And I click on "Select theme" "button" in the "#theme-select-form-boost" "css_element"
+    And I log out
+    When I log in as "student1"
+    And I am on site homepage
+    Then "#access-support-form-sr-link" "css_element" should not exist
+
   Scenario Outline: Setting: Allow accessibility support page without login - Check real user and guest
     Given the following config values are set as admin:
       | config                                 | value     | plugin            |

tests/behat/theme_boost_union_feelsettings_navigation.feature

@@ -136,6 +136,22 @@ Feature: Configuring the theme_boost_union plugin for the "Navigation" tab on th
       | yes     | should      |
       | no      | should not  |
 
+  @javascript
+  Scenario: Setting: Do not show starred courses popover in the navbar if Boost Union is not the active theme (cross-theme check).
+    Given the following config values are set as admin:
+      | config                   | value | plugin            |
+      | shownavbarstarredcourses | yes   | theme_boost_union |
+    And I log in as "admin"
+    And I navigate to "Appearance > Themes" in site administration
+    And I click on "Select theme" "button" in the "#theme-select-form-boost" "css_element"
+    And I log out
+    When I log in as "student1"
+    And I follow "My courses"
+    And I click on ".coursemenubtn" "css_element" in the "//div[contains(@class, 'card course-card') and contains(.,'Course 1')]" "xpath_element"
+    And I click on "Star this course" "link" in the "//div[contains(@class, 'card course-card') and contains(.,'Course 1')]" "xpath_element"
+    And I reload the page
+    Then "nav.navbar #usernavigation .popover-region-favourites" "css_element" should not exist
+
   @javascript
   Scenario: Setting: Show starred courses popover in the navbar (and make sure that I see the right courses there).
     Given the following config values are set as admin:

tests/behat/theme_boost_union_looksettings_mobile.feature

@@ -99,3 +99,17 @@ Feature: Configuring the theme_boost_union plugin for the "Mobile" tab on the "L
     Then I should not see "Touch icon files for iOS list"
     And ".settings-touchiconsios-filelist" "css_element" should not exist
     And Behat debugging is enabled
+
+  @javascript @_file_upload
+  Scenario: Setting: Touch icon files for iOS - Do not ship touch icon files if Boost Union is not the active theme (cross-theme check).
+    Given I log in as "admin"
+    And I navigate to "Appearance > Themes" in site administration
+    And I click on "Select theme" "button" in the "#theme-select-form-boost" "css_element"
+    And Behat debugging is disabled
+    And I navigate to "Appearance > Boost Union > Look" in site administration
+    And I click on "Mobile" "link" in the "#adminsettings .nav-tabs" "css_element"
+    And I upload "theme/boost_union/tests/fixtures/apple-icon-180x180.png" file to "Touch icon files for iOS" filemanager
+    And I press "Save changes"
+    And Behat debugging is enabled
+    And I am on site homepage
+    Then "//head//link[contains(@rel, 'apple-touch-icon')][contains(@sizes, '180x180')][contains(@href, 'pluginfile.php/1/theme_boost_union/touchiconsios')][contains(@href, 'apple-icon-180x180.png')]" "xpath_element" should not exist