Skip to content

Drawers secondary nav bug #1115

@alexdamsted

Description

@alexdamsted

Describe the bug
This is a bug when accessing the /backup/view.php page of a given course.

It seems that the drawers secondary nav related code is not error guarded resulting in the bug.

This may be a workaround to a Moodle core bug instead? I can replicate this problem with theme_boost too.

To Reproduce
Steps to reproduce the behavior:

  1. Access your Moodle site and going to the /backup/view.php page of a given course.
  2. I couldn't seem to replicate this as a siteadmin but rather just as a normal user with course editing/backup/restore permissions.
  3. See the below fatal error output:
Error Exception
---------------
core\output\url_select::__construct():
Argument #1 ($urls) must be of type array, null given

Debug info:
Error code: generalexceptionmessage

Stack trace:
------------
#0 /lib/classes/output/url_select.php:110
   TypeError thrown

#1 /lib/classes/navigation/views/secondary.php:639
   call to core\output\url_select->__construct()

#2 /theme/boost_union/layout/drawers.php:121
   call to core\navigation\views\secondary->get_overflow_menu_data()

#3 /lib/classes/output/core_renderer.php:972
   call to include()

#4 /lib/classes/output/core_renderer.php:888
   call to core\output\core_renderer->render_page_layout()

#5 /lib/classes/output/core_renderer.php:824
   call to core\output\core_renderer->header()

#6 /theme/boost_union/classes/output/core_renderer.php:?
   call to theme_boost_union\output\core_renderer->header()

#7 /lib/classes/output/bootstrap_renderer.php:109
   call to call_user_func_array()

#8 /backup/view.php:50
   call to core\output\bootstrap_renderer->__call()

Expected behavior

  1. The /backup/view.php of a given course should load normally.

Please complete the following information:

  • Moodle Version: 4.5
  • Boost Union Version: MOODLE_405_STABLE
  • OS: [e.g. Windows, Android, iOS]: Windows
  • Browser [e.g. firefox, safari]: Chrome

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething which isn't workingnewSomething which has been reported but has not yet beeen triaged by the team

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions