Make codechecker happy again

Author: abias

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2025-10-15 - Make codechecker happy again
 * 2025-10-15 - Tests: Switch Github actions workflows to reusable workflows by Moodle an Hochschulen e.V.
 
 ### v5.0-r1

classes/set_fields.php

@@ -27,7 +27,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/course/lib.php');
+require_once($CFG->dirroot . '/course/lib.php');
 
 /**
  * Helper functions for tool_coursefields.
@@ -70,7 +70,10 @@ public static function maybe_alter_course_fields($course, $fields) {
                 $fieldname = substr($key, 12);
 
                 // Continue if the corresponding checkbox element was not activated.
-                if (!isset($fields->{'customfieldcheckbox_'.$fieldname}) || $fields->{'customfieldcheckbox_'.$fieldname} != true) {
+                if (
+                    !isset($fields->{'customfieldcheckbox_' . $fieldname}) ||
+                        $fields->{'customfieldcheckbox_' . $fieldname} != true
+                ) {
                     continue;
                 }
 

classes/set_fields_form.php

@@ -64,26 +64,30 @@ public function definition() {
             // If we are dealing with a customfield_textarea fieldtype, the shortname needs special treatment.
             // For now, this special treatment is hardcoded.
             if ($field->get('type') == 'textarea') {
-                $shortname = $shortname.'_editor';
+                $shortname = $shortname . '_editor';
             }
 
             // Get some more field metadata.
-            $elementname = 'customfield_'.$shortname;
+            $elementname = 'customfield_' . $shortname;
             $formattedname = $field->get_formatted_name();
 
             // Add a header to help the user identify the following form element as a group.
-            $headerelementname = 'customfieldheader_'.$shortname;
-            $headerelement = $mform->createElement('static', $headerelementname, '<h4>'.$formattedname.'</h4>');
+            $headerelementname = 'customfieldheader_' . $shortname;
+            $headerelement = $mform->createElement('static', $headerelementname, '<h4>' . $formattedname . '</h4>');
             $mform->insertElementBefore($headerelement, $elementname);
 
             // Add a checkbox element in front of the field to control if this value should be overwritten.
-            $checkboxelementname = 'customfieldcheckbox_'.$shortname;
-            $checkboxelement = $mform->createElement('advcheckbox', $checkboxelementname, '',
-                    get_string('overwritefield', 'tool_coursefields'));
+            $checkboxelementname = 'customfieldcheckbox_' . $shortname;
+            $checkboxelement = $mform->createElement(
+                'advcheckbox',
+                $checkboxelementname,
+                '',
+                get_string('overwritefield', 'tool_coursefields')
+            );
             $mform->insertElementBefore($checkboxelement, $elementname);
 
             // Add a static element in front of the field to inform the admin about the details of the field.
-            $staticelementname = 'customfieldstatic_'.$shortname;
+            $staticelementname = 'customfieldstatic_' . $shortname;
             $staticelementnotes = [];
             if ($field->get_configdata_property('required') == 1) {
                 $staticelementnotes[] = get_string('fieldisrequired', 'tool_coursefields');
@@ -99,8 +103,18 @@ public function definition() {
             // Disable the field as long as the checkbox element is not activated.
             $mform->disabledIf($elementname, $checkboxelementname);
 
-            unset($shortname, $elementname, $formattedname, $headerelementname, $headerelement, $checkboxelementname,
-                    $checkboxelement, $staticelementname, $staticelementnotes, $staticelement);
+            unset(
+                $shortname,
+                $elementname,
+                $formattedname,
+                $headerelementname,
+                $headerelement,
+                $checkboxelementname,
+                $checkboxelement,
+                $staticelementname,
+                $staticelementnotes,
+                $staticelement
+            );
         }
 
         // Get rid of any required rules in this form as these won't validate correctly with the checkbox elements.

index.php

@@ -35,7 +35,8 @@
 $returnurl = new \core\url('/course/management.php', ['categoryid' => $categoryid]);
 
 // Current location.
-$url = new \core\url('/'.$CFG->admin.'/tool/coursefields/index.php',
+$url = new \core\url(
+    '/' . $CFG->admin . '/tool/coursefields/index.php',
     [
         'category' => $categoryid,
     ]
@@ -45,7 +46,7 @@
 $PAGE->set_context($context);
 $PAGE->set_pagelayout('admin');
 $PAGE->set_url($url);
-$PAGE->set_title(get_string('coursecatmanagement') . ': '. get_string('setfields', 'tool_coursefields'));
+$PAGE->set_title(get_string('coursecatmanagement') . ': ' . get_string('setfields', 'tool_coursefields'));
 $PAGE->set_heading($SITE->fullname);
 
 // Create form.
@@ -62,8 +63,11 @@
         ]
     );
     \core\task\manager::queue_adhoc_task($task);
-    redirect($returnurl, get_string('updatequeued', 'tool_coursefields',
-        format_string($category->name, true, ['context' => $context])));
+    redirect($returnurl, get_string(
+        'updatequeued',
+        'tool_coursefields',
+        format_string($category->name, true, ['context' => $context])
+    ));
 } else {
     // Prepare the form.
     $mform->set_data(['category' => $categoryid]);

lib.php

@@ -46,15 +46,15 @@ function tool_coursefields_extend_navigation_category_settings($navigation, $con
          $navigation->add_node(
              navigation_node::create(
                  get_string('setfields', 'tool_coursefields'),
-                    new \core\url(
-                        '/'.$CFG->admin.'/tool/coursefields/index.php',
-                        ['category' => $context->instanceid]
-                    ),
-                    navigation_node::TYPE_SETTING,
-                    null,
-                    null,
-                    new \core\output\pix_icon('i/settings', '')
-                    )
-                );
+                 new \core\url(
+                     '/' . $CFG->admin . '/tool/coursefields/index.php',
+                     ['category' => $context->instanceid]
+                 ),
+                 navigation_node::TYPE_SETTING,
+                 null,
+                 null,
+                 new \core\output\pix_icon('i/settings', '')
+             )
+         );
     }
 }