Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity and build process #45

Open
andrewnicols opened this issue Feb 26, 2019 · 1 comment
Open

Improve clarity and build process #45

andrewnicols opened this issue Feb 26, 2019 · 1 comment

Comments

@andrewnicols
Copy link
Contributor

We should improve our Dockerfile in line with best-practice recommendations in https://github.com/docker-library/official-images/blob/master/README.md#clarity

Specifically we should move all of the commands out of the ADD/RUN syntax and into the main Dockerfile.

We should also look to improve our build process.
I would recommend we look at what PHP, Postgres, and others have done and to have a shell script (update.sh) which takes a matrix of PHP versions, Base image versions (stretch at this time), and generates a Dockerfile in a folder format for each.

@stronk7
Copy link
Member

stronk7 commented Mar 18, 2023

Maybe this can be closed now with all the recent updates performed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants