Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpcs and phpdoc report errors in thirdpartylibs in a subplugin #308

Open
marinaglancy opened this issue Jul 30, 2024 · 1 comment
Open

Comments

@marinaglancy
Copy link
Member

marinaglancy commented Jul 30, 2024

Here is the plugin https://github.com/marinaglancy/moodle-tool_realtime
it has subplugins, one of them (plugin/pusher) has thirdpartylibs.xml that lists a bunch of 3rd party libraries.

This command reports no errors:

moodle-plugin-ci phpcs admin/tool/realtime/plugin/pusher/

However this command reports a bunch of errors in the paths that should be excluded by thirdpartylibs.xml in the pusher plugin:

moodle-plugin-ci phpcs admin/tool/realtime

On top of that, running moodle-plugin-ci from the GHA for the tool_realtime plugin also reports the errors in the paths that should be excluded, see https://github.com/marinaglancy/moodle-tool_realtime/actions/runs/10165832133/job/28114587219 for example

What should I do in this case?

@marinaglancy marinaglancy changed the title Phpcs reports errors in thirdpartylibs in a subplugin Phpcs and phpdoc report errors in thirdpartylibs in a subplugin Jul 30, 2024
@marinaglancy
Copy link
Member Author

As a workaround I added IGNORE_PATHS to gha file to skip these paths when running GHA, and I added a "fake" thirdpartylibs.xml to the tool_realtime plugin (ignored so it is not pushed to github) to skip when running moodle-plugin-ci locally.

But it is just a band-aid, I need to update both of them every time I add a new library in the subplugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant