You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
marinaglancy
changed the title
Phpcs reports errors in thirdpartylibs in a subplugin
Phpcs and phpdoc report errors in thirdpartylibs in a subplugin
Jul 30, 2024
As a workaround I added IGNORE_PATHS to gha file to skip these paths when running GHA, and I added a "fake" thirdpartylibs.xml to the tool_realtime plugin (ignored so it is not pushed to github) to skip when running moodle-plugin-ci locally.
But it is just a band-aid, I need to update both of them every time I add a new library in the subplugin
Here is the plugin https://github.com/marinaglancy/moodle-tool_realtime
it has subplugins, one of them (plugin/pusher) has thirdpartylibs.xml that lists a bunch of 3rd party libraries.
This command reports no errors:
However this command reports a bunch of errors in the paths that should be excluded by thirdpartylibs.xml in the pusher plugin:
On top of that, running moodle-plugin-ci from the GHA for the tool_realtime plugin also reports the errors in the paths that should be excluded, see https://github.com/marinaglancy/moodle-tool_realtime/actions/runs/10165832133/job/28114587219 for example
What should I do in this case?
The text was updated successfully, but these errors were encountered: