Commit ebbed92
authored
Key-Value-Pairs Delta encoding editorial tweaks. (#1366)
#1315 Follow up.
Resubmitting my late-review proposal. I suspect my comment was ignored
because getting a wire-format change into main without late unnecessary
editorial discussion is good. That's why I am resubmitting. Editors, if
I got that wrong, and you like the current wording, feel free to close
this.
~I am not sure where the last-minute change of 2^62-1 to 2^64-1 came
from. I think allowing bigger value than is encodable in a single delta
is wrong. It doesn't really add any value and makes the handling
complex, how is one supposed to encode it if needed without prior pairs?
If I understand that wrongly and there is need for 2^64-1 I think there
should be an explanation somewhere.~
I do think the size limit should be enforced for all Key-Value-Pairs.1 parent 82a1b86 commit ebbed92
1 file changed
+11
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
278 | | - | |
279 | | - | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
280 | 286 | | |
281 | 287 | | |
282 | 288 | | |
| |||
1628 | 1634 | | |
1629 | 1635 | | |
1630 | 1636 | | |
1631 | | - | |
1632 | | - | |
1633 | | - | |
1634 | | - | |
1635 | | - | |
1636 | | - | |
| 1637 | + | |
1637 | 1638 | | |
1638 | 1639 | | |
1639 | 1640 | | |
| |||
3167 | 3168 | | |
3168 | 3169 | | |
3169 | 3170 | | |
3170 | | - | |
3171 | | - | |
| 3171 | + | |
| 3172 | + | |
3172 | 3173 | | |
3173 | 3174 | | |
3174 | 3175 | | |
| |||
0 commit comments