Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of "MainnetLib" #429

Open
MathisGD opened this issue May 6, 2024 · 5 comments · Fixed by #434
Open

Inconsistent naming of "MainnetLib" #429

MathisGD opened this issue May 6, 2024 · 5 comments · Fixed by #434

Comments

@MathisGD
Copy link
Contributor

MathisGD commented May 6, 2024

Sometimes we say Ethereum, sometimes we say mainnet
@MerlinEgalite
Copy link
Contributor

let's switch to Ethereum

@MathisGD
Copy link
Contributor Author

MathisGD commented May 7, 2024

So we modify the contract without redeploying it? Then I would also modify "BaseBundler"

@Rubilmax
Copy link
Collaborator

Rubilmax commented May 7, 2024 •
edited
Loading

I think we should go for MainnetLib, BaseMainnetLib & BaseGoerliLib to avoid having a specific case for BaseLib (which evocates something completely different)

Also because "mainnet" is widely used to talk about ethereum's mainnet

@MathisGD
Copy link
Contributor Author

Why not renaming the "BaseBundler"?

@Rubilmax
Copy link
Collaborator

Because I am less inspired to find an alternative name for the base layer of the bundler than for chains ^^

@MathisGD MathisGD linked a pull request May 14, 2024 that will close this issue
BaseBundler renaming #434
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BaseBundler renaming morpho-org/morpho-blue-bundlers
3 participants
@Rubilmax @MerlinEgalite @MathisGD