fixed spacy manager errors on windows (#348)

Author: mortii

ankimorphs/__init__.py

@@ -57,6 +57,7 @@
 from .generators.generators_window import GeneratorWindow
 from .highlighting.highlight_just_in_time import highlight_morphs_jit
 from .known_morphs_exporter import KnownMorphsExporterDialog
+from .morphemizers import spacy_wrapper
 from .progression.progression_window import ProgressionWindow
 from .recalc import recalc_main
 from .settings import settings_dialog
@@ -88,6 +89,7 @@ def main() -> None:
     gui_hooks.profile_did_open.append(init_browser_menus_and_actions)
     gui_hooks.profile_did_open.append(replace_card_reviewer)
     gui_hooks.profile_did_open.append(text_preprocessing.update_translation_table)
+    gui_hooks.profile_did_open.append(spacy_wrapper.maybe_delete_spacy_venv)
 
     gui_hooks.sync_will_start.append(recalc_on_sync)
 

ankimorphs/morphemizers/spacy_wrapper.py

@@ -5,6 +5,7 @@
 import shutil
 import subprocess
 import sys
+from pathlib import Path
 from types import ModuleType
 from typing import Any
 
@@ -153,7 +154,7 @@ def get_installed_models() -> list[str]:
 
 def _get_am_spacy_venv_python() -> str:
     if is_win:
-        return os.path.join(_get_am_spacy_venv_path(), "Scripts", "python", ".exe")
+        return os.path.join(_get_am_spacy_venv_path(), "Scripts", "python.exe")
     return os.path.join(_get_am_spacy_venv_path(), "bin", "python")
 
 
@@ -168,17 +169,21 @@ def create_spacy_venv() -> None:
     """
 
     spacy_venv_path = _get_am_spacy_venv_path()
+
+    # delete in case it already exists from previously failed attempts
+    shutil.rmtree(spacy_venv_path, ignore_errors=True)
+
     python_path: str | None = venv_binary("python")
     assert python_path is not None
 
     subprocess.run([python_path, "-m", "venv", spacy_venv_path], check=True)
 
     if is_win:
-        spacy_venv_python = os.path.join(spacy_venv_path, "Scripts", "python", ".exe")
+        spacy_venv_python = os.path.join(spacy_venv_path, "Scripts", "python.exe")
     else:
         spacy_venv_python = os.path.join(spacy_venv_path, "bin", "python")
 
-    # make sure pip, setuptools, and wheel are up to date
+    # make sure pip, setuptools, and wheel are up-to-date
     subprocess.run(
         [
             spacy_venv_python,
@@ -201,7 +206,21 @@ def create_spacy_venv() -> None:
 
 
 def delete_spacy_venv() -> None:
-    shutil.rmtree(_get_am_spacy_venv_path())
+    spacy_venv_path = _get_am_spacy_venv_path()
+    try:
+        shutil.rmtree(spacy_venv_path)
+    except PermissionError:
+        # windows does not like deleting files in use, so we add this flag file
+        # and we delete the venv on startup if the file exists
+        (Path(spacy_venv_path) / ".delete_me").touch()
+
+
+def maybe_delete_spacy_venv() -> None:
+    # gracefully delete spacy venv on windows
+    spacy_venv_path = _get_am_spacy_venv_path()
+    flag = Path(spacy_venv_path, ".delete_me")
+    if flag.exists():
+        shutil.rmtree(spacy_venv_path)
 
 
 def install_model(model_name: str) -> None:

docs/src/contributors.md

@@ -18,7 +18,7 @@ Vilhelm-Ian, CodeWithMa, ashprice, aleksejrs, HQYang1979, soliviantar, buster-bl
 cocowash, asayake-b5, quietmansoath, MichaelPetre, xofm31, knoebelja, xuiqzy, Jcuhfehl, fuquasteve, pallas42, syfgk,
 jahnke, jsteel44, iwouldrathernotusegithub, tanhoaian01, drkthomp, Kirchheim, zeroeightysix, Gardengul, wolearyc,
 Pedrubik2000, RyanMcEntire, BobvanSchendel, khanguyenwk, buqamura, Rct567, rwmpelstilzchen, bie-zheng, IncontinentCell,
-mdraves91, dae.
+mdraves91, dae, AtilioA.
 
 ### MorphMan (v5.0-qt6-alpha.1)