Commit 032cfdb
committed
Cleanup
This points out a potential problem with a previous fix for compatibility with https://github.com/pyqt/python-qt. Before, these members were tested against existing members, but now they are blindly added via `setattr`. It's safe, since we've already tested these and know for sure that they aren't being overwritten. But it still opens the door for these to one day override a newly added member.
Luckily, this is only relevant until the next major release, upon which they are all discarded.1 parent f97fde5 commit 032cfdb
1 file changed
+1
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
375 | 375 | | |
376 | 376 | | |
377 | 377 | | |
| 378 | + | |
378 | 379 | | |
379 | 380 | | |
380 | 381 | | |
| |||
387 | 388 | | |
388 | 389 | | |
389 | 390 | | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | 391 | | |
395 | 392 | | |
0 commit comments