Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

this looks a bit dangerous #1

Open
raimohanska opened this issue Feb 8, 2015 · 0 comments · May be fixed by #2
Open

this looks a bit dangerous #1

raimohanska opened this issue Feb 8, 2015 · 0 comments · May be fixed by #2

Comments

@raimohanska
Copy link

On line 33, you use the same variable name driverSockets as in the larger scope. The variable in the larger scope happens to be declared after this line, so it'll work, but if you just moved the declaration higher, you'd end up mutating the global variable instead. I suggest you rename this var :)

https://github.com/houmio/houmio-bridge/blob/master/src/bridge.coffee#L33

@raimohanska raimohanska linked a pull request Feb 8, 2015 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant