-
Notifications
You must be signed in to change notification settings - Fork 84
Jani choicelab #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jani choicelab #662
Conversation
|
I tried the implementation on csma.-2-2 model (both JANI and PRISM can be found here: csma.2-2.v1.zip) and it seems it works mostly fine, however, there is one additional label with no name when parsing JANI. PRISM model output:Model type: MDP (sparse) State Labels: 2 labels
Choice Labels: 8 labels
JANI model output:Model type: MDP (sparse) State Labels: 2 labels
Choice Labels: 9 labels
|
|
Could you create a smaller file to show where these empty labels come from? |
|
Ok I see what's happening. If there are empty action labels [] in the PRISM file then the corresponding edges in the JANI file don't have any "action" property. While building models from PRISM these are ignored when it comes to choice labeling, but here a new "empty" label is created for these choices. In this zip jani-empty-labels-example.zip there are 2 versions of the same model. In tiny_rewards all actions have labels and therefore this is not a problem, in tiny_rewards2 there is one action with no label leading to this behaviour. |
|
Ok, so the expected solution is that for empty labels, I just dont add a label? :-) |
|
Yes, that should be all. |
tquatmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Tim Quatmann <[email protected]>
Add choice label building for JANI. Fixes #661