Refactor FXIOS-13748 [Telemetry] Migrate FxAWebViewTelemetry to use mock telemetry (#30245)

* Bugfix FXIOS-13685 [Bookmarks] Fix navigation bar partial display in New Folder screen on landscape

* Refactor FXIOS-13748 [Telemetry] Use TelemetryWrapperProtocol in
  FxAWebViewTelemetry

  - Add dependency injection for TelemetryWrapperProtocol in FxAWebViewTelemetry
  - Mock TelemetryWrapper in SyncTelemetryTests to avoid calling Glean during tests
  - Add 7 new test methods to verify recordTelemetry() behavior

* Update firefox-ios/RustFxA/FxAWebViewTelemetry.swift

Co-authored-by: lmarceau <[email protected]>

* Add MockTelemetryWrapper to test target

---------

Co-authored-by: lmarceau <[email protected]>

Author: vee-kamunya

firefox-ios/Client.xcodeproj/project.pbxproj

@@ -1386,6 +1386,7 @@
 		96EB6C3827D821B800A9D159 /* HistoryPanelViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 96EB6C3727D821B800A9D159 /* HistoryPanelViewModel.swift */; };
 		96EB6C3E27D9266500A9D159 /* HistoryActionables.swift in Sources */ = {isa = PBXBuildFile; fileRef = 96EB6C3D27D9266500A9D159 /* HistoryActionables.swift */; };
 		96F8DA49280452CA00E53239 /* GleanPlumbContextProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = 96F8DA48280452CA00E53239 /* GleanPlumbContextProvider.swift */; };
+		A0B6D6632EB49C0400574E34 /* MockTelemetryWrapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5A9A09D328B01D8700B6F51E /* MockTelemetryWrapper.swift */; };
 		A83E5B1A1C1DA8BF0026D912 /* image.gif in Resources */ = {isa = PBXBuildFile; fileRef = A83E5B181C1DA8BF0026D912 /* image.gif */; };
 		A83E5B1B1C1DA8BF0026D912 /* image.png in Resources */ = {isa = PBXBuildFile; fileRef = A83E5B191C1DA8BF0026D912 /* image.png */; };
 		A83E5B1D1C1DA8D80026D912 /* UIPasteboardExtensionsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A83E5B1C1C1DA8D80026D912 /* UIPasteboardExtensionsTests.swift */; };
@@ -18180,6 +18181,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				43D6D6A327E535FF00F47485 /* FxALoginRegistrationTelemetryTests.swift in Sources */,
+				A0B6D6632EB49C0400574E34 /* MockTelemetryWrapper.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

firefox-ios/RustFxA/FxAWebViewTelemetry.swift

@@ -3,6 +3,7 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/
 
 import Foundation
+import Common
 
 enum FxAFlow {
     case completed
@@ -40,6 +41,11 @@ class FxAWebViewTelemetry {
     // There are two valid started flow
     // signup and signin
     var validStartedFlow: FxAUrlPathStartedFlow?
+    private let telemetryWrapper: TelemetryWrapperProtocol
+
+    init(telemetryWrapper: TelemetryWrapperProtocol = TelemetryWrapper.shared) {
+          self.telemetryWrapper = telemetryWrapper
+    }
 
     func getFlowFromUrl(fxaUrl: URL?) -> FxAUrlPathStartedFlow? {
         guard let url = fxaUrl,
@@ -84,7 +90,7 @@ class FxAWebViewTelemetry {
                 eventObject = .fxaConfirmSignInToken
             }
         }
-        TelemetryWrapper.recordEvent(
+        telemetryWrapper.recordEvent(
             category: .firefoxAccount,
             method: .view,
             object: eventObject)

firefox-ios/firefox-ios-tests/Tests/SyncTelemetryTests/FxALoginRegistrationTelemetryTests.swift

@@ -14,17 +14,19 @@ struct MockFxAUrls {
     static let mockSignInTockenUrl =  URL(string: "https://accounts.firefox.com/oauth/signin_token_code/")!
 }
 
-// TODO: FXIOS-13748 - Migrate SyncTelemetryTests to use mock telemetry or GleanWrapper
 class SyncTelemetryTests: XCTestCase {
     var fxaWebViewTelemetry: FxAWebViewTelemetry!
+    var telemetryWrapper: MockTelemetryWrapper!
 
     override func setUp() {
         super.setUp()
-        fxaWebViewTelemetry = FxAWebViewTelemetry()
+        telemetryWrapper = MockTelemetryWrapper()
+        fxaWebViewTelemetry = FxAWebViewTelemetry(telemetryWrapper: telemetryWrapper)
     }
 
     override func tearDown() {
         fxaWebViewTelemetry = nil
+        telemetryWrapper = nil
         super.tearDown()
     }
 
@@ -51,4 +53,64 @@ class SyncTelemetryTests: XCTestCase {
         XCTAssertNotNil(flow)
         XCTAssertEqual(flow, FxAUrlPathStartedFlow.confirmSignupCode)
     }
+
+    // MARK: - recordTelemetry() tests
+
+      func testRecordTelemetry_signinStarted_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .signinStarted))
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 1)
+          XCTAssertEqual(telemetryWrapper.recordedCategories.first, .firefoxAccount)
+          XCTAssertEqual(telemetryWrapper.recordedMethods.first, .view)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.first, .fxaLoginWebpage)
+      }
+
+      func testRecordTelemetry_signinCompleted_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .signinStarted))
+          fxaWebViewTelemetry.recordTelemetry(for: .completed)
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 2)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.last, .fxaLoginCompleteWebpage)
+      }
+
+      func testRecordTelemetry_signinTokenCode_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .signinTokenCode))
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 1)
+          XCTAssertEqual(telemetryWrapper.recordedCategories.first, .firefoxAccount)
+          XCTAssertEqual(telemetryWrapper.recordedMethods.first, .view)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.first, .fxaConfirmSignInToken)
+      }
+
+      func testRecordTelemetry_signupStarted_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .signupStarted))
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 1)
+          XCTAssertEqual(telemetryWrapper.recordedCategories.first, .firefoxAccount)
+          XCTAssertEqual(telemetryWrapper.recordedMethods.first, .view)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.first, .fxaRegistrationWebpage)
+      }
+
+      func testRecordTelemetry_signupCompleted_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .signupStarted))
+          fxaWebViewTelemetry.recordTelemetry(for: .completed)
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 2)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.last, .fxaRegistrationCompletedWebpage)
+      }
+
+      func testRecordTelemetry_confirmSignupCode_recordsCorrectEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .startedFlow(type: .confirmSignupCode))
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 1)
+          XCTAssertEqual(telemetryWrapper.recordedCategories.first, .firefoxAccount)
+          XCTAssertEqual(telemetryWrapper.recordedMethods.first, .view)
+          XCTAssertEqual(telemetryWrapper.recordedObjects.first, .fxaConfirmSignUpCode)
+      }
+
+      func testRecordTelemetry_completedWithoutStartedFlow_doesNotRecordEvent() {
+          fxaWebViewTelemetry.recordTelemetry(for: .completed)
+
+          XCTAssertEqual(telemetryWrapper.recordEventCallCount, 0)
+      }
 }