Refactor FXIOS-13820 Enable SEC by default (#29945)

* [FXIOS-13820] Enable SEC by default

* Attempt at fixing crash in BR, still investigating

* Revert "Attempt at fixing crash in BR, still investigating"

This reverts commit 88df4c7.

* Temporarily disable testQuickSearchEngines to see if that fixes BR run

* Unit test fix

* Fix UI tests

Author: mattreaganmozilla

firefox-ios/Client/Frontend/Browser/SearchEngines/SearchEngineFlagManager.swift

@@ -2,10 +2,13 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/
 
+import Common
+
 struct SearchEngineFlagManager {
     /// Whether Search Engine Consolidation is enabled.
     /// If enabled, search engines are fetched from Remote Settings rather than our pre-bundled XML files.
     static var isSECEnabled: Bool {
+        guard !AppConstants.isRunningUnitTest && !AppConstants.isRunningUITests else { return false }
         return LegacyFeatureFlagsManager.shared.isFeatureEnabled(.searchEngineConsolidation, checking: .buildOnly)
     }
 }

firefox-ios/nimbus-features/searchEngineConsolidationFeature.yaml

@@ -8,12 +8,12 @@ features:
         description: >
           Enables the feature
         type: Boolean
-        default: false
+        default: true
     defaults:
       - channel: beta
         value:
-          enabled: false
+          enabled: true
       - channel: developer
         value:
-          enabled: false
+          enabled: true