Refactor [Summarizer] Only use invalidResponse for http error responses. (#28441)

fix: forward http error codes

Author: issammani

BrowserKit/Sources/SummarizeKit/Backend/AppleIntelligence/FoundationModelsSummarizer.swift

@@ -69,7 +69,7 @@ final class FoundationModelsSummarizer: SummarizerProtocol {
                /// When `next()` returns nil, the underlying stream has no more data
                /// returning nil in turn ends the AsyncThrowingStream
                guard let chunk = try await responseStream.next() else { return nil }
-               guard let stringChunk = chunk as? String else { throw SummarizerError.invalidResponse }
+               guard let stringChunk = chunk as? String else { throw SummarizerError.invalidChunk }
                return stringChunk
            } catch {
                throw self.mapError(error)

BrowserKit/Sources/SummarizeKit/Backend/LLM/LiteLLMSummarizer.swift

@@ -70,7 +70,7 @@ final class LiteLLMSummarizer: SummarizerProtocol {
         case LiteLLMClientError.invalidResponse(let statusCode) where statusCode == 429:
             return .rateLimited
         case LiteLLMClientError.invalidResponse(let statusCode):
-            return .unknown(LiteLLMClientError.invalidResponse(statusCode: statusCode))
+            return .invalidResponse(statusCode: statusCode)
         case is CancellationError: return .cancelled
         case let e as LiteLLMClientError: return .unknown(e)
         default: return .unknown(error)

BrowserKit/Sources/SummarizeKit/Backend/SummarizerError.swift

@@ -12,7 +12,9 @@ enum SummarizerError: Error, LocalizedError, Sendable {
     case busy
     case safetyBlocked
     case unsupportedLanguage
-    case invalidResponse
+    case invalidResponse(statusCode: Int)
+    case unableToExtractContent
+    case invalidChunk
     case cancelled
     case noContent
     case unknown(Error)
@@ -30,6 +32,8 @@ enum SummarizerError: Error, LocalizedError, Sendable {
         case .cancelled: return ""
         case .invalidResponse: return ""
         case .noContent: return ""
+        case .invalidChunk: return ""
+        case .unableToExtractContent: return ""
         case .unknown: return ""
         }
     }
@@ -40,7 +44,7 @@ enum SummarizerError: Error, LocalizedError, Sendable {
         case .contentTooLong: self = .tooLong
         case .documentLanguageUnsupported: self = .unsupportedLanguage
         case .documentNotReadable: self = .cancelled
-        case nil: self = .invalidResponse
+        case nil: self = .unableToExtractContent
         }
     }
 }

BrowserKit/Sources/SummarizeKit/SummarizationError+LocalizedErrorsViewModel.swift

@@ -7,7 +7,10 @@ import Foundation
 extension SummarizerError {
     var shouldRetrySummarizing: Bool {
         return switch self {
-        case .busy, .noContent, .invalidResponse:
+        case .busy,
+             .noContent,
+             .invalidResponse,
+             .invalidChunk:
             true
         default:
             false
@@ -20,11 +23,14 @@ extension SummarizerError {
             localizedErrors.rateLimitedMessage
         case .safetyBlocked:
             localizedErrors.unsafeContentMessage
-        case .unsupportedLanguage, .invalidResponse, .tooLong:
+        case .unsupportedLanguage,
+             .invalidResponse,
+             .tooLong,
+             .unableToExtractContent:
             localizedErrors.summarizationNotAvailableMessage
         case .noContent, .busy:
             localizedErrors.pageStillLoadingMessage
-        case .unknown, .cancelled:
+        case .unknown, .cancelled, .invalidChunk:
             localizedErrors.genericErrorMessage
         }
     }

BrowserKit/Tests/SummarizeKitTests/FoundationModelsSummarizerTests.swift

@@ -125,6 +125,9 @@ extension SummarizerError: @retroactive Equatable {
              (.safetyBlocked, .safetyBlocked),
              (.unsupportedLanguage, .unsupportedLanguage),
              (.invalidResponse, .invalidResponse),
+             (.unableToExtractContent, .unableToExtractContent),
+             (.invalidChunk, .invalidChunk),
+             (.noContent, .noContent),
              (.cancelled, .cancelled):
             return true
 

BrowserKit/Tests/SummarizeKitTests/LiteLLMSummarizerTests.swift

@@ -20,6 +20,14 @@ final class LiteLLMSummarizerTests: XCTestCase {
         }
     }
 
+    func testSummarizeNonStreamingMapsInvalidResponse() async throws {
+        let rateLimitError = LiteLLMClientError.invalidResponse(statusCode: 502)
+        let subject = createSubject(respondWithError: rateLimitError)
+        await assertSummarizeThrows(.invalidResponse(statusCode: 502)) {
+            _ = try await subject.summarize("t")
+        }
+    }
+
     func testSummarizeNonStreamingMapsUnknownError() async throws {
         let randomError = NSError(domain: "Random error", code: 1)
         let subject = createSubject(respondWithError: randomError)
@@ -49,6 +57,15 @@ final class LiteLLMSummarizerTests: XCTestCase {
         }
     }
 
+    func testSummarizeStreamedMapsInvalidResponse() async throws {
+        let rateLimitError = LiteLLMClientError.invalidResponse(statusCode: 567)
+        let subject = createSubject(respondWithError: rateLimitError)
+        let stream = subject.summarizeStreamed("t")
+        await assertSummarizeThrows(.invalidResponse(statusCode: 567)) {
+            for try await _ in stream { }
+        }
+    }
+
     func testSummarizeStreamedMapsUnknownError() async throws {
         let randomError = NSError(domain: "Random error", code: 1)
         let subject = createSubject(respondWithError: randomError)