Skip to content

Annotations are part of methods identity #38

@agi90

Description

@agi90

Annotations are part of methods identity in apilint, which causes apilint to not recognize when annotations are added or removed and instead causing apilint to think that the method has been removed giving a confusing error.

E.g. apilint gives this error:

Error: Method removed or incompatible change
    in method public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean)
    in public final class RuntimeTelemetry
    in package org.mozilla.geckoview
    at line 846

for this change

   public final class RuntimeTelemetry {
-    method public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean);
+    method @android.support.annotation.AnyThread public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean);
   }

While really what we would want is "Annotation added" which should probably not be a compat issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions