Fix deprecation warnings related to datetime.utcnow (#1912)

`utcnow` is deprecated in python 3.12 in favor of `now(UTC)`.

Author: Eijebong

api/src/shipit_api/admin/api.py

@@ -243,7 +243,7 @@ def update_release_status(name, body):
     status = body["status"]
     release.status = status
     if status == "shipped":
-        release.completed = datetime.datetime.utcnow()
+        release.completed = datetime.datetime.now(datetime.UTC)
     session.commit()
 
     logger.info("Status of %s changed to %s", release.name, status)
@@ -283,7 +283,7 @@ def phase_signoff(name, phase, body):
     if not set(users_ldap).intersection(set(ldap_group)):
         abort(401, f"User `{users_email}` is not in the `{signoff.permissions}`")
 
-    signoff.completed = datetime.datetime.utcnow()
+    signoff.completed = datetime.datetime.now(datetime.UTC)
     signoff.signed = True
     signoff.completed_by = users_email
 

api/src/shipit_api/admin/xpi.py

@@ -176,7 +176,7 @@ def phase_signoff(name, phase, body):
     if not set(users_ldap).intersection(set(ldap_group)) and not XPI_LAX_SIGN_OFF:
         abort(401, f"User `{users_email}` is not in the `{signoff.permissions}`")
 
-    signoff.completed = datetime.datetime.utcnow()
+    signoff.completed = datetime.datetime.now(datetime.UTC)
     signoff.signed = True
     signoff.completed_by = users_email
 

api/src/shipit_api/common/models.py

@@ -90,7 +90,7 @@ class Phase(db.Model, PhaseBase):
     task_id = sa.Column(sa.String, nullable=False)
     task = sa.Column(sa.Text, nullable=False)
     context = sa.Column(sa.Text, nullable=False)
-    created = sa.Column(sa.DateTime, default=datetime.datetime.utcnow)
+    created = sa.Column(sa.DateTime, default=lambda: datetime.datetime.now(datetime.UTC))
     scheduled_at = sa.Column(sa.DateTime)
     scheduled_by = sa.Column(sa.String)
     release_id = sa.Column(sa.Integer, sa.ForeignKey("shipit_api_releases.id"))
@@ -139,7 +139,7 @@ class Release(db.Model, ReleaseBase):
     release_eta = sa.Column(sa.DateTime)
     status = sa.Column(sa.String)  # TODO: move to Enum: shipped, abandoned, scheduled
     phases = sqlalchemy.orm.relationship("Phase", order_by=Phase.id, back_populates="release", lazy="selectin")
-    created = sa.Column(sa.DateTime, default=datetime.datetime.utcnow)
+    created = sa.Column(sa.DateTime, default=lambda: datetime.datetime.now(datetime.UTC))
     completed = sa.Column(sa.DateTime)
 
     phase_class = Phase
@@ -259,7 +259,7 @@ class XPIPhase(db.Model, PhaseBase):
     task_id = sa.Column(sa.String, nullable=False)
     task = sa.Column(sa.Text, nullable=False)
     context = sa.Column(sa.Text, nullable=False)
-    created = sa.Column(sa.DateTime, default=datetime.datetime.utcnow)
+    created = sa.Column(sa.DateTime, default=lambda: datetime.datetime.now(datetime.UTC))
     scheduled_at = sa.Column(sa.DateTime)
     scheduled_by = sa.Column(sa.String)
     release_id = sa.Column(sa.Integer, sa.ForeignKey("shipit_api_xpi_releases.id"))
@@ -279,7 +279,7 @@ class XPIRelease(db.Model, ReleaseBase):
     revision = sa.Column(sa.String, nullable=False)
     status = sa.Column(sa.String)
     phases = sqlalchemy.orm.relationship("XPIPhase", order_by=XPIPhase.id, back_populates="release", lazy="selectin")
-    created = sa.Column(sa.DateTime, default=datetime.datetime.utcnow)
+    created = sa.Column(sa.DateTime, default=lambda: datetime.datetime.now(datetime.UTC))
     completed = sa.Column(sa.DateTime)
 
     phase_class = XPIPhase