Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hard-coding the Firefox Nightly version information in our configuration #1462

Closed
gabrielBusta opened this issue May 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gabrielBusta
Copy link
Member

This issue pertains to the merge duty step outlined here.

Currently, the Nightly version information is hard-coded into the shipit configuration file:

# FIREFOX_NIGHTLY version is hard coded and requires a human to update it after
# the latest Nightly builds are available on CDNs after version bump (merge
# day).
# We could have used the in-tree version, but there can be race conditions,
# e.g. version bumped, but still no builds available.
#
# This version also defines the mobile nightly version (i.e.: Fenix)
FIREFOX_NIGHTLY = "127.0a1"

This requires a manual source change every time there is a new Nightly version, followed by a shipit deployment. To reduce manual intervention from release engineering, we should enhance shipit to make it possible to update the current Nightly version without needing code modifications or application deployments.

This improvement will help automate this merge-day task and supports the objectives of Issue #1418.

@gabrielBusta gabrielBusta added the enhancement New feature or request label May 7, 2024
@gabrielBusta
Copy link
Member Author

gabrielBusta commented May 7, 2024

 # We could have used the in-tree version, but there can be race conditions, 
 # e.g. version bumped, but still no builds available

We could have an API to bump the version, if needed, from a shipitscript task in the Nightly graph. Kinda like bouncerscript:

current_version = get_nightly_version(product_name, path)
if current_version == payload_version:
    log.info("No-op. Nightly version is the same")
    continue

This task could be downstream of the builds somewhere to avoid these race conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant