Skip to content

Fixup integration tests #1007

Open
Open
@pjenvey

Description

@pjenvey

We should redo tools/integration_tests/test_storage.py from scratch, with:

  • the original test_storage.py file from server-syncstorage master added in a separate commit
  • any modifications made to it in a separate commit persisted for easy history viewing

The file was incorrectly imported from some older version, it lacked some needed additions (somewhat fixed in 8c280cc)

but it's also missing some other patches (e.g. the one made to test_that_we_dont_resurrect_committed_batches for Spanner).

Another bug with it is it sets the self.distant flag to False whichs causes some failing test to pass that shouldn't be ran.

Metadata

Metadata

Assignees

No one assigned

    Labels

    3Estimate - m - This is a small change, but there's some uncertainty.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions