Bug 1995662 - guard create_login_store_with_nss_keymanager

Author: jo

CHANGELOG.md

@@ -13,6 +13,10 @@
   - When the keydb feature is enabled, `ensure_nss_initialized` is disabled in
     favor of `ensure_nss_initialized_with_profile_dir`.
 
+### Logins
+- `create_login_store_with_nss_keymanager` returns an `ApiResult` now, instead
+  of just panicking.
+
 # v146.0 (_2025-11-10_)
 
 ## ✨ What's New ✨

components/logins/src/lib.rs

@@ -53,7 +53,8 @@ pub fn create_managed_encdec(key_manager: Arc<dyn KeyManager>) -> Arc<ManagedEnc
 pub fn create_login_store_with_static_key_manager(path: String, key: String) -> Arc<LoginStore> {
     let encdec: ManagedEncryptorDecryptor =
         ManagedEncryptorDecryptor::new(Arc::new(StaticKeyManager::new(key)));
-    Arc::new(LoginStore::new(path, Arc::new(encdec)).unwrap())
+    let store = LoginStore::new(path, Arc::new(encdec)).expect("error setting up LoginStore");
+    Arc::new(store)
 }
 
 // Create a LoginStore with NSSKeyManager by passing in a db path and a PrimaryPasswordAuthenticator.
@@ -65,9 +66,10 @@ pub fn create_login_store_with_static_key_manager(path: String, key: String) ->
 pub fn create_login_store_with_nss_keymanager(
     path: String,
     primary_password_authenticator: Arc<dyn PrimaryPasswordAuthenticator>,
-) -> Arc<LoginStore> {
+) -> ApiResult<Arc<LoginStore>> {
     let encdec: ManagedEncryptorDecryptor = ManagedEncryptorDecryptor::new(Arc::new(
         NSSKeyManager::new(primary_password_authenticator),
     ));
-    Arc::new(LoginStore::new(path, Arc::new(encdec)).unwrap())
+    let store = LoginStore::new(path, Arc::new(encdec))?;
+    Ok(Arc::new(store))
 }