Skip to content

Commit ef63796

Browse files
committed
Add ohttp support to the Android megazord
Upgrading `ohttp` to the latest version, which is needed to make the builds work.
1 parent 1f73e45 commit ef63796

File tree

6 files changed

+102
-20
lines changed

6 files changed

+102
-20
lines changed

Cargo.lock

Lines changed: 8 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/as-ohttp-client/Cargo.toml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,8 @@ uniffi = { version = "0.29.0" }
1414
thiserror = "2"
1515
parking_lot = "0.12"
1616
rusqlite = { version = "0.37.0", features = ["bundled"] }
17-
18-
[dependencies.bhttp]
19-
git = "https://github.com/martinthomson/ohttp.git"
20-
rev = "bf6a983845cc0b540effb3a615e92d914dfcfd0b"
21-
22-
[dependencies.ohttp]
23-
default-features = false
24-
git = "https://github.com/martinthomson/ohttp.git"
25-
rev = "bf6a983845cc0b540effb3a615e92d914dfcfd0b"
26-
features = ["client", "server", "app-svc", "external-sqlite"]
17+
bhttp = "0.7.1"
18+
ohttp = { version = "0.7.1", default-features = false, features = ["client", "server", "app-svc", "external-sqlite"] }
2719

2820
[build-dependencies]
2921
uniffi = { version = "0.29.0", features=["build"]}

components/viaduct/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ thiserror = "2"
2424
uniffi = { version = "0.29.0" }
2525
tokio = { version = "1", features = ["rt-multi-thread"], optional = true }
2626
hyper = { version = "0.14", features = ["client", "http1", "http2", "tcp"], optional = true }
27-
bhttp = { git = "https://github.com/martinthomson/ohttp.git", rev = "bf6a983845cc0b540effb3a615e92d914dfcfd0b", optional = true }
28-
ohttp = { git = "https://github.com/martinthomson/ohttp.git", rev = "bf6a983845cc0b540effb3a615e92d914dfcfd0b", features = ["client", "server", "app-svc", "external-sqlite"], default-features = false, optional = true }
27+
bhttp = { version = "0.7.1", optional = true }
28+
ohttp = { version = "0.7.1", features = ["client", "server", "app-svc", "external-sqlite"], default-features = false, optional = true }
2929

3030
[features]
3131
default = []

megazords/full/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ places = { path = "../../components/places" }
1919
push = { path = "../../components/push" }
2020
remote_settings = { path = "../../components/remote_settings" }
2121
rust-log-forwarder = { path = "../../components/support/rust-log-forwarder" }
22-
# disable ohttp for now until a fix is in for Android; add "features = ["ohttp"]" for enabling ohttp for viaduct
23-
viaduct = { path = "../../components/viaduct" }
22+
viaduct = { path = "../../components/viaduct", features = ["ohttp"] }
2423
nimbus-sdk = { path = "../../components/nimbus" }
2524
autofill = { path = "../../components/autofill" }
2625
crashtest = { path = "../../components/crashtest" }

megazords/full/DEPENDENCIES.md

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ the details of which are reproduced below.
2828
* [MIT License: tracing, tracing-attributes, tracing-core, tracing-subscriber](#mit-license-tracing-tracing-attributes-tracing-core-tracing-subscriber)
2929
* [MIT License: weedle2](#mit-license-weedle2)
3030
* [CC0-1.0 License: base16](#cc0-10-license-base16)
31+
* [ISC License: libloading](#isc-license-libloading)
3132
* [ISC License: ring](#isc-license-ring)
3233
* [BSD-2-Clause License: arrayref](#bsd-2-clause-license-arrayref)
34+
* [BSD-3-Clause License: bindgen](#bsd-3-clause-license-bindgen)
3335
* [BSD-3-Clause License: protobuf](#bsd-3-clause-license-protobuf)
3436
* [Zlib License: foldhash](#zlib-license-foldhash)
3537
* [Unicode-3.0 License: icu_casemap, icu_casemap_data, icu_collections, icu_locale, icu_locale_core, icu_locale_data, icu_normalizer, icu_normalizer_data, icu_properties, icu_properties_data, icu_provider, icu_segmenter, icu_segmenter_data, litemap, potential_utf, tinystr, writeable, yoke, yoke-derive, zerofrom, zerofrom-derive, zerotrie, zerovec, zerovec-derive](#unicode-30-license-icu_casemap-icu_casemap_data-icu_collections-icu_locale-icu_locale_core-icu_locale_data-icu_normalizer-icu_normalizer_data-icu_properties-icu_properties_data-icu_provider-icu_segmenter-icu_segmenter_data-litemap-potential_utf-tinystr-writeable-yoke-yoke-derive-zerofrom-zerofrom-derive-zerotrie-zerovec-zerovec-derive)
@@ -445,13 +447,16 @@ The following text applies to code linked from these dependencies:
445447
[autocfg](https://github.com/cuviper/autocfg),
446448
[base64](https://github.com/marshallpierce/rust-base64),
447449
[basic-toml](https://github.com/dtolnay/basic-toml),
450+
[bhttp](https://github.com/martinthomson/ohttp),
448451
[bitflags](https://github.com/bitflags/bitflags),
449452
[block-buffer](https://github.com/RustCrypto/utils),
450453
[camino](https://github.com/camino-rs/camino),
451454
[cargo-platform](https://github.com/rust-lang/cargo),
452455
[cc](https://github.com/rust-lang/cc-rs),
456+
[cexpr](https://github.com/jethrogb/rust-cexpr),
453457
[cfg-if](https://github.com/alexcrichton/cfg-if),
454458
[chrono](https://github.com/chronotope/chrono),
459+
[clang-sys](https://github.com/KyleMayes/clang-sys),
455460
[core-foundation-sys](https://github.com/servo/core-foundation-rs),
456461
[cpufeatures](https://github.com/RustCrypto/utils),
457462
[crypto-common](https://github.com/RustCrypto/traits),
@@ -492,6 +497,7 @@ The following text applies to code linked from these dependencies:
492497
[log](https://github.com/rust-lang/log),
493498
[minimal-lexical](https://github.com/Alexhuszagh/minimal-lexical),
494499
[num-traits](https://github.com/rust-num/num-traits),
500+
[ohttp](https://github.com/martinthomson/ohttp),
495501
[once_cell](https://github.com/matklad/once_cell),
496502
[parking_lot](https://github.com/Amanieu/parking_lot),
497503
[parking_lot_core](https://github.com/Amanieu/parking_lot),
@@ -1589,6 +1595,27 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15891595
See the License for the specific language governing permissions and
15901596
limitations under the License.
15911597
1598+
```
1599+
-------------
1600+
## ISC License: libloading
1601+
1602+
The following text applies to code linked from these dependencies:
1603+
[libloading](https://github.com/nagisa/rust_libloading/)
1604+
1605+
```
1606+
Copyright © 2015, Simonas Kazlauskas
1607+
1608+
Permission to use, copy, modify, and/or distribute this software for any purpose with or without
1609+
fee is hereby granted, provided that the above copyright notice and this permission notice appear
1610+
in all copies.
1611+
1612+
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
1613+
SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE
1614+
AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
1615+
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
1616+
NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
1617+
THIS SOFTWARE.
1618+
15921619
```
15931620
-------------
15941621
## ISC License: ring
@@ -1647,6 +1674,44 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
16471674
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
16481675
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
16491676
1677+
```
1678+
-------------
1679+
## BSD-3-Clause License: bindgen
1680+
1681+
The following text applies to code linked from these dependencies:
1682+
[bindgen](https://github.com/rust-lang/rust-bindgen)
1683+
1684+
```
1685+
BSD 3-Clause License
1686+
1687+
Copyright (c) 2013, Jyun-Yan You
1688+
All rights reserved.
1689+
1690+
Redistribution and use in source and binary forms, with or without
1691+
modification, are permitted provided that the following conditions are met:
1692+
1693+
* Redistributions of source code must retain the above copyright notice, this
1694+
list of conditions and the following disclaimer.
1695+
1696+
* Redistributions in binary form must reproduce the above copyright notice,
1697+
this list of conditions and the following disclaimer in the documentation
1698+
and/or other materials provided with the distribution.
1699+
1700+
* Neither the name of the copyright holder nor the names of its
1701+
contributors may be used to endorse or promote products derived from
1702+
this software without specific prior written permission.
1703+
1704+
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
1705+
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
1706+
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
1707+
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
1708+
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
1709+
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
1710+
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
1711+
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
1712+
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
1713+
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
1714+
16501715
```
16511716
-------------
16521717
## BSD-3-Clause License: protobuf

megazords/full/android/dependency-licenses.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,10 @@ the details of which are reproduced below.
104104
<name>Apache License 2.0: basic-toml</name>
105105
<url>https://github.com/dtolnay/basic-toml/blob/master/LICENSE-APACHE</url>
106106
</license>
107+
<license>
108+
<name>Apache License 2.0: bhttp</name>
109+
<url>https://github.com/martinthomson/ohttp/blob/main/LICENSE-APACHE</url>
110+
</license>
107111
<license>
108112
<name>Apache License 2.0: bitflags</name>
109113
<url>https://github.com/bitflags/bitflags/blob/main/LICENSE-APACHE</url>
@@ -124,6 +128,10 @@ the details of which are reproduced below.
124128
<name>Apache License 2.0: cc</name>
125129
<url>https://github.com/rust-lang/cc-rs/blob/main/LICENSE-APACHE</url>
126130
</license>
131+
<license>
132+
<name>Apache License 2.0: cexpr</name>
133+
<url>https://github.com/jethrogb/rust-cexpr/blob/master/LICENSE-APACHE</url>
134+
</license>
127135
<license>
128136
<name>Apache License 2.0: cfg-if</name>
129137
<url>https://github.com/alexcrichton/cfg-if/blob/main/LICENSE-APACHE</url>
@@ -132,6 +140,10 @@ the details of which are reproduced below.
132140
<name>Apache License 2.0: chrono</name>
133141
<url>https://github.com/chronotope/chrono/blob/main/LICENSE.txt</url>
134142
</license>
143+
<license>
144+
<name>Apache License 2.0: clang-sys</name>
145+
<url>https://github.com/KyleMayes/clang-sys/blob/master/LICENSE.txt</url>
146+
</license>
135147
<license>
136148
<name>Apache License 2.0: core-foundation-sys</name>
137149
<url>https://github.com/servo/core-foundation-rs/blob/main/LICENSE-APACHE</url>
@@ -292,6 +304,10 @@ the details of which are reproduced below.
292304
<name>Apache License 2.0: num-traits</name>
293305
<url>https://github.com/rust-num/num-traits/blob/master/LICENSE-APACHE</url>
294306
</license>
307+
<license>
308+
<name>Apache License 2.0: ohttp</name>
309+
<url>https://github.com/martinthomson/ohttp/blob/main/LICENSE-APACHE</url>
310+
</license>
295311
<license>
296312
<name>Apache License 2.0: once_cell</name>
297313
<url>https://github.com/matklad/once_cell/blob/master/LICENSE-APACHE</url>
@@ -640,6 +656,10 @@ the details of which are reproduced below.
640656
<name>CC0-1.0 License: base16</name>
641657
<url>https://github.com/thomcc/rust-base16/blob/master/LICENSE-APACHE</url>
642658
</license>
659+
<license>
660+
<name>ISC License: libloading</name>
661+
<url>https://github.com/nagisa/rust_libloading/blob//master/LICENSE</url>
662+
</license>
643663
<license>
644664
<name>ISC License: ring</name>
645665
<url>https://github.com/briansmith/ring/blob/master/LICENSE</url>
@@ -648,6 +668,10 @@ the details of which are reproduced below.
648668
<name>BSD-2-Clause License: arrayref</name>
649669
<url>https://github.com/droundy/arrayref/blob/master/LICENSE</url>
650670
</license>
671+
<license>
672+
<name>BSD-3-Clause License: bindgen</name>
673+
<url>https://github.com/rust-lang/rust-bindgen/blob/main/LICENSE</url>
674+
</license>
651675
<license>
652676
<name>BSD-3-Clause License: protobuf</name>
653677
<url>https://github.com/protocolbuffers/protobuf/blob/master/LICENSE</url>

0 commit comments

Comments
 (0)