-
Notifications
You must be signed in to change notification settings - Fork 375
Refactor badge.displayBrowserActionBadge to be used in both popup.js and messageHandler.js #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
May I work on this if it is still open? Thanks 🙂 |
Yes, you're welcome to work on it if you like. I haven't had time to triage or review many PRs though, so if you submit a PR see if you can make it small/concise? Thanks! |
While doing the initial setup using npm. A warning occurred: |
Yes, a new issue for that would be good. Thanks. |
Hello @groovecoder I am a 2019 Outreachy applicant, May I work on this as my first contribution? Thank you. |
Hi @Aishat-Akinyemi - yes you can pick this one up. |
I'm assigning this to myself to mark it as being assigned. Please let me know if you decide to work on a different issue. |
I will start working on it, thank you. |
I have submitted a Pull request that fixes this issue [https://github.com//pull/1523#issue-326806982] |
@Aishat-Akinyemi Can you open up a PR for us to review? |
@
@maxxcrawford I already opened up a PR #1523 that fixes this issue and issue #1513 . You commented on it saying I should make some changes. I have made those changes as requested, kindly check the PR #1523 . Or should I make a new PR from scratch, kindly advise, thank you. |
@Aishat-Akinyemi Nope – This works! I'll review. Thank you! |
See #921 (comment) for details.
The text was updated successfully, but these errors were encountered: