Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom checkboxes not rendered #18021

Open
nclm opened this issue Apr 29, 2024 · 2 comments · May be fixed by #18907
Open

Custom checkboxes not rendered #18021

nclm opened this issue Apr 29, 2024 · 2 comments · May be fixed by #18907
Labels
form-acroform

Comments

@nclm
Copy link

nclm commented Apr 29, 2024 •
edited
Loading

PDF files:

Configuration:

  • Web browser and its version: Firefox 126.0b5
  • Operating system and its version: macOS 14.3
  • PDF.js version: unknown
  • Is a browser extension: no?

Steps to reproduce the problem:

  1. Open the PDFs above.
  2. Go on pages after the cover.

What is the expected behavior?
Custom checkboxes should be rendered.

  • Acrobat & Apple Preview:
Screenshot 2024-04-29 at 16 14 11 Screenshot 2024-04-29 at 16 15 21 Screenshot 2024-04-29 at 16 17 08
  • Chrome (works too but add blue overlays):
Screenshot 2024-04-29 at 16 17 40 Screenshot 2024-04-29 at 16 17 45 Screenshot 2024-04-29 at 16 17 55

What went wrong?
Custom checkboxes are not rendered at all.

  • Firefox:
Screenshot 2024-04-29 at 16 19 50 Screenshot 2024-04-29 at 16 20 07 Screenshot 2024-04-29 at 16 20 19
@nclm
Copy link
Author

nclm commented Apr 30, 2024

Might be related to #12746 but not sure. Both PDFs are made with InDesign and have custom form elements, but the other is about buttons and they do appear (though not interactively), and this one is about checkboxes and they don‘t appear (but are interactive).

@momerjaved
Copy link

momerjaved commented May 1, 2024 •
edited
Loading

I would like to contribute and fix this issue, can you please assign it to me ? Also if you could tell which JS file(s) should I start to debug for the fix ?

calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 15, 2024
@calixteman
Use the checkboxes and radio button appearances as defined in the pdf…
df97617 
… to render them in the annotation layer (bug 1802506)

The idea is to generate two operator lists for the Yes/Off states and render them on a separate canvas.
These canvases are then attached the annotation and we modify their display depending on the input state.

It fixes mozilla#18021.
@calixteman calixteman linked a pull request Oct 15, 2024 that will close this issue
Draft
calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 15, 2024
@calixteman
Use the checkboxes and radio button appearances as defined in the pdf…
7f6cde6 
… to render them in the annotation layer (bug 1802506)

The idea is to generate two operator lists for the Yes/Off states and render them on a separate canvas.
These canvases are then attached the annotation and we modify their display depending on the input state.

It fixes mozilla#18021.
calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 16, 2024
@calixteman
Use the checkboxes and radio button appearances as defined in the pdf…
b9b6b20 
… to render them in the annotation layer (bug 1802506)

The idea is to generate two operator lists for the Yes/Off states and render them on a separate canvas.
These canvases are then attached the annotation and we modify their display depending on the input state.

It fixes mozilla#18021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
form-acroform
Projects
None yet
Milestone
No milestone
3 participants
@nclm @timvandermeij @momerjaved