-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOOGLE_APPLICATION_CREDENTIALS is not documented and not Docker friendly #3427
Comments
I can't find any code or pull request that used |
We use https://github.com/gerynugrh/heroku-google-application-credentials-buildpack, which requires these variables. It is indeed not documented. |
Should we have a special hidden file that is copied over like the .env file? |
BTW, not sure how reliable this is for env in $(grep -r 'os.environ.get("' pontoon --include="*.py" | sed -n 's/.*os.environ.get("\([^"]*\)".*/\1/p' | sort | uniq); do
if ! grep -qr "$env" --include="*.rst" .; then
echo "$env"
fi
done Some of these seem unrelated, but others should probably be documented
|
Looks like Pontoon is set up in Heroku with a
GOOGLE_CREDENTIALS
setting that is unused.I had to look into the code to find
GOOGLE_APPLICATION_CREDENTIALS
, which was introduced in #2873 but not documented.This is supposed to point to a local JSON file, which makes its use in Docker very complicated, as such file is removed every time the container is rebuilt. Not completely sure how that works on Heroku.
The text was updated successfully, but these errors were encountered: