Why doesn't _isProbablyVisible check visibility: hidden?

[mikesnare]

We've run into this bug: #769 and the reason seems to be that visibility: hidden isn't being checked in _isProbablyVisible. The site has duplicate images hidden somewhere using that approach to hiding.

Since you're looking for display: none, it seems odd that you are not also looking for visibility: hidden. But it's so odd that I figure there must be a reason, so before I monkey patch I wanted to check to see what that reason might be.

Thanks!

[aehlke]

I tried looking through older tickets but couldn't find any leads on why this is omitted. I would recommend just adding it and checking test results.

The method was originally added here it looks like #283 which was solving a specific issue that didn't include visibility: hidden. I think it just wasn't relevant to the problem the author was solving at the time.

[gijsk]

I think we've just not tried particularly hard. Once you go down the rabbithole (what about opacity? What about overflow: hidden combined with a 0 width/height? What about...) it's pretty deep.

I've no objections to adding visibility: hidden checks, though.

[gijsk]

We merged #817 so let's close this out. Thanks!