Add null | undefined to parse results. Fixes #937 #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative option here (slightly more invasive) could be to coalesce everything in the object returned from return {
title: this._articleTitle ?? undefined,
byline: metadata.byline || this._articleByline ?? undefined,
dir: this._articleDir ?? undefined,
lang: this._articleLang ?? undefined,
content: this._serializer(articleContent) ?? undefined,
textContent: textContent ?? undefined,
length: textContent.length ?? undefined,
excerpt: metadata.excerpt ?? undefined,
siteName: metadata.siteName || this._articleSiteName ?? undefined,
publishedTime: metadata.publishedTime ?? undefined,
};(or null instead of undefined if that is the preference). |
cmkm
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937.
This PR might be too much of a swing in the opposite direction. The reason I've included null and undefined in all props is because it's difficult to trace exactly which props are always assigned a value versus which might be null versus which might be null or undefined.
I've got a branch locally where I'm slowly annotating everything with types, but that is slow going. In the meantime, erring this way is arguably more appropriate.