Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken textContent functionality #949

Closed
timlib opened this issue Jan 16, 2025 · 1 comment
Closed

Remove broken textContent functionality #949

timlib opened this issue Jan 16, 2025 · 1 comment

Comments

@timlib
Copy link

timlib commented Jan 16, 2025

Per prior issues, the textContent functionality does not produce valid text output. Issues have been closed as WONTFIX, so the best solution is to remove the functionality as it does not produce output which a typical user would rely on, and is therefore worse than not having it.

#779
#939

@gijsk
Copy link
Contributor

gijsk commented Jan 27, 2025

Issues have been closed as WONTFIX

Except they haven't, #779 is still open? The other one I intended to close as a duplicate of 779, but for some reason github either didn't give me that option or did something else. I've fixed that now.

As noted in #779, I'd take a patch that tries to use innerText first, which would work with compliant DOM implementations. jsdom has an outstanding feature request for it, see jsdom/jsdom#1245 .

Let's try to keep the discussion in one place.

@gijsk gijsk closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants